Skip to content

Commit b561aa4

Browse files
committed
Issue #453 avoid error when angular name used a variable
1 parent 6768269 commit b561aa4

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

rules/file-name.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,10 @@ module.exports = {
124124
if (type === undefined || (type === 'service' && node.callee.object.name === '$provide')) {
125125
return;
126126
}
127-
127+
128+
if(!name){
129+
return;
130+
}
128131
expectedName = filenameUtil.createExpectedName(name, type, options);
129132

130133
if (expectedName !== filename) {

test/file-name.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,24 @@ var commonFalsePositives = require('./utils/commonFalsePositives');
1515
var eslintTester = new RuleTester();
1616
eslintTester.run('file-name', rule, {
1717
valid: [{
18+
// basic module
19+
filename: 'app.module.js',
20+
options: [{
21+
typeSeparator: 'dot',
22+
ignoreTypeSuffix: true,
23+
ignorePrefix: 'fs'
24+
}],
25+
code: `(function () {
26+
27+
var mod = 'shared.sales';
28+
29+
angular.module(mod + 'shared.sales.core.angular', ['ngCookies', 'ngRoute', 'ngLocale', 'ngResource', 'ngAnimate', 'ngSanitize', 'ngMessages', 'ngIOS9UIWebViewPatch']);
30+
31+
angular.module(mod + 'shared.sales.thirdparty', ['tmh.dynamicLocale', 'gettext', 'ngMaterial', 'md.data.table', 'fixed.table.header', 'as.sortable', 'ngCsv', 'telemetry']);
32+
33+
angular.module(mod, [mod + '.core.angular', mod + '.thirdparty']);
34+
})();`
35+
}, {
1836
// basic module
1937
filename: 'myModule.js',
2038
code: 'angular.module("myModule", []);'

0 commit comments

Comments
 (0)