Skip to content

Commit 97b0a58

Browse files
committed
Merge pull request #242 from Gillespie59/development
0.13.0
2 parents 044621c + 9367799 commit 97b0a58

File tree

23 files changed

+727
-389
lines changed

23 files changed

+727
-389
lines changed

.travis.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
language: node_js
2-
node_js:
3-
- "0.10"
4-
before_script:
5-
- chmod +x ./node_modules/.bin/gulp
6-
install: npm install
7-
script: gulp
8-
after_script: "cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js"
1+
language: node_js
2+
node_js:
3+
- "0.10"
4+
after_script: "cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js"

README.md

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ Since the 0.0.4 release, some rules defined in [John Papa's Guideline](https://g
1818

1919
- [Usage with shareable config](#usage-with-shareable-config)
2020
- [Usage without shareable config](#usage-without-shareable-config)
21-
- [Sample configs](sample-configs)
2221
- [Defaults](#defaults)
2322
- [Rules](#rules)
2423
- [Need your help](#need-your-help)
@@ -90,14 +89,6 @@ Users may use the shareable [eslint-config-angular](https://github.com/dustinspe
9089

9190

9291

93-
## Sample configs
94-
95-
- [demo/npm](https://github.com/Gillespie59/eslint-plugin-angular/tree/master/demo/npm) (launch: npm run lint)
96-
- [demo/grunt](https://github.com/Gillespie59/eslint-plugin-angular/tree/master/demo/grunt) (launch: grunt)
97-
- [demo/gulp](https://github.com/Gillespie59/eslint-plugin-angular/tree/master/demo/gulp) (launch: gulp)
98-
99-
100-
10192
## Defaults
10293

10394
```json
@@ -172,8 +163,9 @@ Users may use the shareable [eslint-config-angular](https://github.com/dustinspe
172163
| controller-name | All your controllers should have a name starting with the parameter you can define in your config object. The second parameter can be a Regexp wrapped in quotes. ("controller-name": [2, "ng"]) [Y123](https://github.com/johnpapa/angular-styleguide#style-y123), [Y124](https://github.com/johnpapa/angular-styleguide#style-y124)|
173164
| deferred | When you want to create a new promise, you should not use the $q.deferred anymore. Prefer the new syntax : $q(function(resolve, reject){}) |
174165
| definedundefined | You should use the angular.isUndefined or angular.isDefined methods instead of using the keyword undefined. We also check the use of !angular.isUndefined and !angular.isDefined (should prefer the reverse function)|
175-
| di | All your DI should use the same syntax : the Array or function syntaxes ("di": [2, "function or array"])|
166+
| di | All your DI should use the same syntax : the Array, function, or $inject syntaxes ("di": [2, "array, function, or $inject"])|
176167
| di-order | Injected dependencies should be sorted alphabetically. If the second parameter is set to false, values which start and end with an underscore those underscores are stripped. This means for example that `_$httpBackend_` goes before `_$http_`. |
168+
| di-unused | Unused dependencies should not be injected. |
177169
| directive-name | All your directives should have a name starting with the parameter you can define in your config object. The second parameter can be a Regexp wrapped in quotes. You can not prefix your directives by "ng" (reserved keyword for AngularJS directives) ("directive-name": [2, "ng"]) [Y073](https://github.com/johnpapa/angular-styleguide#style-y073), [Y126](https://github.com/johnpapa/angular-styleguide#style-y126) |
178170
| directive-restrict | Not all directive restrictions may be desirable. Also it might be desirable to define default restrictions, or explicitly not. The default configuration limits the restrictions `AE` [Y074](https://github.com/johnpapa/angular-styleguide#style-y074) and disallows explicitly specifying a default. ("directive-restrict": [0, {"restrict": "AE", "explicit": "never"}]) |
179171
| document-service | Instead of the default document object, you should prefer the AngularJS wrapper service $document. [Y180](https://github.com/johnpapa/angular-styleguide#style-y180) |
@@ -208,7 +200,7 @@ Users may use the shareable [eslint-config-angular](https://github.com/dustinspe
208200
| typecheck-function | You should use the angular.isFunction method instead of the default JavaScript implementation (typeof function(){} ==="[object Function]"). |
209201
| typecheck-number | You should use the angular.isNumber method instead of the default JavaScript implementation (typeof 3 === "[object Number]"). |
210202
| typecheck-object | You should use the angular.isObject method instead of the default JavaScript implementation (typeof {} === "[object Object]"). |
211-
| typecheck-regexp | You should use the angular.isRegexp method instead of the default JavaScript implementation (toString.call(/^A/) === "[object RegExp]"). |
203+
| typecheck-regexp | DEPRECATED! You should use the angular.isRegexp method instead of the default JavaScript implementation (toString.call(/^A/) === "[object RegExp]"). |
212204
| typecheck-string | You should use the angular.isString method instead of the default JavaScript implementation (typeof "" === "[object String]"). |
213205
| watchers-execution | For the execution of the watchers, the $digest method will start from the scope in which we call the method. This will cause an performance improvement comparing to the $apply method, who start from the $rootScope |
214206
| window-service | Instead of the default window object, you should prefer the AngularJS wrapper service $window. [Y180](https://github.com/johnpapa/angular-styleguide#style-y180) |

demo/grunt/.eslintrc

Lines changed: 0 additions & 13 deletions
This file was deleted.

demo/grunt/Gruntfile.js

Lines changed: 0 additions & 16 deletions
This file was deleted.

demo/grunt/app/index.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

demo/grunt/package.json

Lines changed: 0 additions & 17 deletions
This file was deleted.

demo/gulp/.eslintrc

Lines changed: 0 additions & 13 deletions
This file was deleted.

demo/gulp/app/index.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

demo/gulp/gulpfile.js

Lines changed: 0 additions & 16 deletions
This file was deleted.

demo/gulp/package.json

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)