Add tests for some internal functions

These tests uncover some issues that need to be looked over.

Author: remcohaszing

gulpfile.js

@@ -18,7 +18,7 @@ gulp.task('test', function(cb) {
         .pipe(istanbul()) // Covering files
         .pipe(istanbul.hookRequire()) // Force `require` to return covered files
         .on('finish', function() {
-            gulp.src(['test/*.js'])
+            gulp.src(['test/**/*.js'])
                 .pipe(mocha())
                 .pipe(istanbul.writeReports()) // Creating the reports after tests runned
                 .on('end', cb);

package.json

@@ -14,9 +14,10 @@
   },
   "homepage": "https://github.com/Gillespie59/eslint-plugin-angularjs",
   "devDependencies": {
-    "chai": "^3.2.0",
+    "chai": "^3.3.0",
     "coveralls": "^2.11.4",
     "eslint": "^1.3.1",
+    "espree": "^2.2.5",
     "gulp": "^3.9.0",
     "gulp-eslint": "^1.0.0",
     "gulp-istanbul": "^0.10.0",

test/utils/utils.js

@@ -0,0 +1,98 @@
+'use strict';
+
+/* eslint-env mocha */
+/* eslint-disable no-unused-expressions */
+
+var espree = require('espree');
+var expect = require('chai').expect;
+
+var utils = require('../../rules/utils/utils');
+
+
+describe('convertPrefixToRegex', function() {
+    it('should not handle non-string objects', function() {
+        var obj = {};
+        expect(utils.convertPrefixToRegex(obj) === obj).to.be.true;
+    });
+
+    xit('should not convert a string ending and starting with a / to a Regex', function() {
+        expect(utils.convertPrefixToRegex('/app/'.source)).to.equal('app.*');
+    });
+
+    it('should not convert a regulat string a Regex', function() {
+        expect(utils.convertPrefixToRegex('app').source).to.equal('app.*');
+    });
+});
+
+describe('convertStringToRegex', function() {
+    xit('should not convert a string ending and starting with a / to a Regex', function() {
+        expect(utils.convertStringToRegex('/app/'.source)).to.equal('app');
+    });
+
+    it('should not convert a regulat string a Regex', function() {
+        expect(utils.convertStringToRegex('app').source).to.equal('app');
+    });
+});
+
+describe('isAngularControllerDeclaration', function() {
+    it('should return true if the function call chained from a module definition declares a controller', function() {
+        var ast = espree.parse('angular.module("", []).controller("", function() {});');
+        expect(utils.isAngularControllerDeclaration(ast.body[0].expression)).to.be.true;
+    });
+
+    it('should return true if the function call chained from a module getter declares a controller', function() {
+        var ast = espree.parse('angular.module("").controller("", function() {});');
+        expect(utils.isAngularControllerDeclaration(ast.body[0].expression)).to.be.true;
+    });
+
+    xit('should return false if a controller function from some variable is called', function() {
+        var ast = espree.parse('app.controller("", function() {});');
+        expect(utils.isAngularControllerDeclaration(ast.body[0].expression)).to.be.false;
+    });
+
+    it('should return true if a referenced angular module declares a controller', function() {
+        var ast = espree.parse('var app = angular.module("");app.controller("", function() {});');
+        expect(utils.isAngularControllerDeclaration(ast.body[1].expression)).to.be.true;
+    });
+
+    it('should return false if too few arguments are passed', function() {
+        var ast = espree.parse('angular.module("").controller("");');
+        expect(utils.isAngularControllerDeclaration(ast.body[0].expression)).to.be.false;
+    });
+});
+
+describe('isAngularModuleDeclaration', function() {
+    it('should return true for an Angular module declaration', function() {
+        var ast = espree.parse('angular.module("", []);');
+        expect(utils.isAngularModuleDeclaration(ast.body[0].expression)).to.be.true;
+    });
+
+    it('should return false for an Angular module getter', function() {
+        var ast = espree.parse('angular.module("");');
+        expect(utils.isAngularModuleDeclaration(ast.body[0].expression)).to.be.false;
+    });
+});
+
+describe('isAngularModuleGetter', function() {
+    xit('should return false for an Angular module declaration', function() {
+        var ast = espree.parse('angular.module("", []);');
+        expect(utils.isAngularModuleGetter(ast.body[0].expression)).to.be.false;
+    });
+
+    it('should return true for an Angular module getter', function() {
+        var ast = espree.parse('angular.module("");');
+        expect(utils.isAngularModuleGetter(ast.body[0].expression)).to.be.true;
+    });
+});
+
+describe('isAngularRunSection', function() {
+    xit('should return true if the call defines a run function', function() {
+        var ast = espree.parse('angular.module("").run(function() {});');
+        expect(utils.isAngularRunSection(ast.body[0].expression)).to.be.true;
+    });
+
+    xit('should return false is a run is called on a random object', function() {
+        var ast = espree.parse('app.run();');
+        expect(utils.isAngularRunSection(ast.body[0].expression)).to.be.false;
+    });
+});