chore: remove unused/legacy item

Author: Elenterius

src/datagen/java/com/github/elenterius/biomancy/datagen/lang/EnglishLangProvider.java

@@ -509,10 +509,6 @@ private void addItemTranslations() {
 				
 				Furthermore it has the ability to convert patches of dirt into grass or force spread mycelium.
 				""");
-		addItem(ModItems.GIFT_SAC, "Gift Sac", """
-				Looks like some objects are wrapped in an organic layer of skin. Might be filled with items or toxin if your language is set to German.
-								
-				Right Click the Sac to retrieve the Items.""");
 		addItem(ModItems.ACID_BUCKET, "Gastric Acid Bucket");
 		addItem(ModItems.GELLING_AGENT, "Gellant", "A gelatinous substance which turns liquids into a gel without altering its taste and other major properties.\nUseful for increasing the stability of volatile things.");
 		addItem(ModItems.GRENADE_CASING, "Grenade Casing", "Outer grenade casing made of a hard organic material designed to rupture or detonate on impact.");

src/datagen/java/com/github/elenterius/biomancy/datagen/lang/PirateLangProvider.java

@@ -437,10 +437,6 @@ private void addItemTranslations() {
 				 - Sailin' through: Increasin' ta' chance to get through yer target's armor
 				 - Numbin' Hands: Preventin' ya from hurtin' the thing ya be injectin'""");
 		addItem(ModItems.FERTILIZER, "Witches' Fertilizer", "Fertilizer that causes yer plants ta' grow quickly, even for Sugar reeds, cactus, verruca o' nether and tall one's flower.");
-		addItem(ModItems.GIFT_SAC, "Sac o' Giftin'", """
-				It be lookin' like some loot be wrapped in a layer o' skin. Might be filled with loot if ye be German.
-								
-				Right Click ta' Sac to retrieve yer loot.""");
 		addItem(ModItems.ACID_BUCKET, "Bucket o' Acid");
 
 		addItem(ModItems.RAVENOUS_CLAWS, "Multi-Cutlass o' Hunger", """

src/datagen/java/com/github/elenterius/biomancy/datagen/models/ModItemModelProvider.java

@@ -89,7 +89,6 @@ protected void registerModels() {
 		basicItem(ModItems.NUTRIENT_BAR);
 		basicItem(ModItems.BLOOMBERRY);
 		serumItem(ModItems.VIAL);
-		basicItem(ModItems.GIFT_SAC);
 		basicItem(ModItems.FERTILIZER);
 		overlayItem(ModItems.ESSENCE);
 

src/generated/resources/assets/biomancy/lang/en_pt.json

@@ -74,8 +74,6 @@
   "item.biomancy.injector.tooltip": "A simple tool that be usin' a sharp needle ta' quickly and forcefully inject Serums inta Mobs an' Players.\n\nCan be infused with:\n - Sailin' through: Increasin' ta' chance to get through yer target's armor\n - Numbin' Hands: Preventin' ya from hurtin' the thing ya be injectin'",
   "item.biomancy.fertilizer": "Witches' Fertilizer",
   "item.biomancy.fertilizer.tooltip": "Fertilizer that causes yer plants ta' grow quickly, even for Sugar reeds, cactus, verruca o' nether and tall one's flower.",
-  "item.biomancy.gift_sac": "Sac o' Giftin'",
-  "item.biomancy.gift_sac.tooltip": "It be lookin' like some loot be wrapped in a layer o' skin. Might be filled with loot if ye be German.\n\nRight Click ta' Sac to retrieve yer loot.",
   "item.biomancy.acid_bucket": "Bucket o' Acid",
   "item.biomancy.ravenous_claws": "Multi-Cutlass o' Hunger",
   "item.biomancy.ravenous_claws.tooltip": "Extremely hungry an' vicious Claws forged by starvin' yer livin' flesh and slappin' claws onto it.\n\nRepair yer famished claws by feedin' them wit' grub in yer inventory, as ya' would fill a Pouch.\n\nKillin' Mobs with these claws be grantin' ya' humors, which allow ya' to use ta' Berserker's Rage.",

src/generated/resources/assets/biomancy/lang/en_us.json

@@ -74,8 +74,6 @@
   "item.biomancy.injector.tooltip": "A simple device which utilizes a razor sharp needle to quickly and forcefully inject Serums into Mobs and Players.\n\nCan be enchanted with:\n - Piercing: Increases the chance to pierce through armor\n - Anesthetic Touch: Nullifies the damage from the needle",
   "item.biomancy.fertilizer": "Bio-Alchemical Fertilizer",
   "item.biomancy.fertilizer.tooltip": "The Fertilizer induces hyper-growth in plants maturing them fully. It even affects bone-meal resistant plants such as:\n- sugarcane\n- cactus\n- nether wart\n- chorus\n\nFurthermore it has the ability to convert patches of dirt into grass or force spread mycelium.\n",
-  "item.biomancy.gift_sac": "Gift Sac",
-  "item.biomancy.gift_sac.tooltip": "Looks like some objects are wrapped in an organic layer of skin. Might be filled with items or toxin if your language is set to German.\n\nRight Click the Sac to retrieve the Items.",
   "item.biomancy.acid_bucket": "Gastric Acid Bucket",
   "item.biomancy.gelling_agent": "Gellant",
   "item.biomancy.gelling_agent.tooltip": "A gelatinous substance which turns liquids into a gel without altering its taste and other major properties.\nUseful for increasing the stability of volatile things.",

src/generated/resources/assets/biomancy/models/item/gift_sac.json

@@ -85,7 +85,6 @@ public static String createRLString(String path) {
 			.icon(() -> new ItemStack(ModItems.LIVING_FLESH.get()))
 			.displayItems((params, output) -> {
 				Set<RegistryObject<? extends Item>> hiddenItems = Set.of(
-						ModItems.GIFT_SAC,
 						ModItems.ESSENCE,
 						ModItems.GUIDE_BOOK,
 						ModItems.DEV_ARM_CANNON

src/main/java/com/github/elenterius/biomancy/BiomancyMod.java

@@ -88,7 +88,6 @@ public final class ModItems {
 	public static final RegistryObject<SimpleItem> PRIMORDIAL_CORE = registerSimpleItem("primordial_core", ModRarities.VERY_RARE);
 	public static final RegistryObject<SimpleItem> LIVING_FLESH = registerItem("living_flesh", props -> new SimpleItem(props.food(ModFoods.LIVING_FLESH).rarity(ModRarities.VERY_RARE)));
 	public static final RegistryObject<EssenceItem> ESSENCE = registerItem("essence", EssenceItem::new);
-	public static final RegistryObject<GiftSacItem> GIFT_SAC = registerItem("gift_sac", props -> new GiftSacItem(props.stacksTo(1).rarity(ModRarities.ULTRA_RARE)));
 
 	//# Tools
 	public static final RegistryObject<GuideBookItem> GUIDE_BOOK = registerItem("guide_book", props -> new GuideBookItem(props.stacksTo(1).rarity(ModRarities.RARE)));
@@ -97,7 +96,6 @@ public final class ModItems {
 	public static final RegistryObject<InjectorItem> INJECTOR = registerItem("injector", props -> new InjectorItem(props.durability(200).rarity(ModRarities.RARE)));
 	public static final RegistryObject<RavenousClawsItem> RAVENOUS_CLAWS = registerItem("ravenous_claws", props -> new RavenousClawsItem(ModTiers.BIOFLESH, 4f, 3.5f, 250, props.rarity(ModRarities.VERY_RARE)));
 	public static final RegistryObject<CausticGunbladeItem> CAUSTIC_GUNBLADE = registerItem("caustic_gunblade", props -> new CausticGunbladeItem(200, props.stacksTo(1).rarity(ModRarities.VERY_RARE)));
-	public static final RegistryObject<DevArmCannonItem> DEV_ARM_CANNON = registerItem("dev_arm_cannon", props -> new DevArmCannonItem(props.stacksTo(1).durability(ModTiers.BIOFLESH.getUses()).rarity(ModRarities.ULTRA_RARE)));
 	public static final RegistryObject<SimpleItem> GRENADE_CASING = registerSimpleItem("grenade_casing");
 	public static final RegistryObject<GrenadeItem> TOXIN_GRENADE = registerItem("toxin_grenade", GrenadeItem::new);
 	public static final RegistryObject<GrenadeItem> ACID_GRENADE = registerItem("acid_grenade", GrenadeItem::new);
@@ -124,6 +122,9 @@ public final class ModItems {
 
 	public static final RegistryObject<MaykerBannerPatternItem> MASCOT_BANNER_PATTERNS = registerItem("mascot_patterns", props -> new MaykerBannerPatternItem(ModBannerPatterns.TAG_MASCOT, props));
 
+	//## Dev
+	public static final RegistryObject<DevArmCannonItem> DEV_ARM_CANNON = registerItem("dev_arm_cannon", props -> new DevArmCannonItem(props.stacksTo(1).durability(ModTiers.BIOFLESH.getUses()).rarity(ModRarities.ULTRA_RARE)));
+
 	//# Block Items
 
 	//## Machine

src/main/java/com/github/elenterius/biomancy/init/ModItems.java

@@ -1,16 +1,11 @@
 package com.github.elenterius.biomancy.inventory;
 
-import com.github.elenterius.biomancy.init.ModItems;
-import com.github.elenterius.biomancy.item.GiftSacItem;
 import net.minecraft.nbt.CompoundTag;
 import net.minecraft.nbt.ListTag;
 import net.minecraft.nbt.Tag;
 import net.minecraft.world.item.ItemStack;
 import net.minecraftforge.items.ItemStackHandler;
 
-import java.util.ArrayList;
-import java.util.List;
-
 public class FixedSizeItemStackHandler extends ItemStackHandler implements SerializableItemHandler {
 
 	public FixedSizeItemStackHandler(int size) {
@@ -40,36 +35,14 @@ public void deserializeNBT(CompoundTag tag) {
 		setSize(stacks.size()); //fixed size
 
 		ListTag list = tag.getList("Items", Tag.TAG_COMPOUND);
-		boolean isOverloaded = list.size() > stacks.size();
-
-		if (!isOverloaded) {
-			for (int i = 0; i < list.size(); i++) {
-				CompoundTag itemTag = list.getCompound(i);
-				int slotIndex = itemTag.getInt("Slot");
-
-				if (slotIndex >= 0 && slotIndex < stacks.size()) {
-					stacks.set(slotIndex, ItemStack.of(itemTag));
-				}
-			}
-		}
-		else {
-			List<CompoundTag> overloadedItems = new ArrayList<>();
-			int maxIndex = stacks.size() - 1;
 
-			for (int i = 0; i < list.size(); i++) {
-				CompoundTag itemTag = list.getCompound(i);
-				int slotIndex = itemTag.getInt("Slot");
+		for (int i = 0; i < list.size(); i++) {
+			CompoundTag itemTag = list.getCompound(i);
+			int slotIndex = itemTag.getInt("Slot");
 
-				if (slotIndex >= 0 && slotIndex < maxIndex) {
-					stacks.set(slotIndex, ItemStack.of(itemTag));
-				}
-				else {
-					overloadedItems.add(itemTag.copy());
-				}
+			if (slotIndex >= 0 && slotIndex < stacks.size()) {
+				stacks.set(slotIndex, ItemStack.of(itemTag));
 			}
-
-			ItemStack giftSac = GiftSacItem.createFromItemTags(ModItems.GIFT_SAC.get(), overloadedItems);
-			stacks.set(maxIndex, giftSac);
 		}
 
 		onLoad();