Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert crash on onchaind in replay_tx_hash_add #8131

Closed
vincenzopalazzo opened this issue Mar 1, 2025 · 0 comments · Fixed by #8132
Closed

assert crash on onchaind in replay_tx_hash_add #8131

vincenzopalazzo opened this issue Mar 1, 2025 · 0 comments · Fixed by #8132

Comments

@vincenzopalazzo
Copy link
Contributor

I still need to look inside the code but probably there are other people that can look at it before me

Looks like related to related to the replay_tx_hash_add function in onchain_control.c

2025-02-28T23:00:22.699Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: billboard: 1 outputs unresolved: waiting confirmation that we spent DELAYED_OUTPUT_TO_US (eff7682b91034395d0ff8d5d3b8d9f118e36339cf8cdfe6e840d21187ae48e83:3) using OUR_DELAYED_RETURN_TO_WALLET
2025-02-28T23:00:27.087Z DEBUG   plugin-folgore_plugin: Log pruned 171 entries (mem 10513389 -> 2760614)
2025-02-28T23:00:27.280Z DEBUG   plugin-folgore_plugin: call get block by height
2025-02-28T23:00:27.280Z INFO    plugin-folgore_plugin: cln request {\"height\":851031}
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: Got new message WIRE_ONCHAIND_DEPTH
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: FUNDING_TRANSACTION/FUNDING_OUTPUT->OUR_UNILATERAL depth 7400
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: OUR_UNILATERAL/ANCHOR_TO_THEM->SELF depth 7400
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: OUR_UNILATERAL/ANCHOR_TO_US->SELF depth 7400
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: OUR_UNILATERAL/OUTPUT_TO_THEM->SELF depth 7400
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: billboard: 1 outputs unresolved: waiting confirmation that we spent DELAYED_OUTPUT_TO_US (eff7682b91034395d0ff8d5d3b8d9f118e36339cf8cdfe6e840d21187ae48e83:3) using OUR_DELAYED_RETURN_TO_WALLET
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: Got new message WIRE_ONCHAIND_DEPTH
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: billboard: 1 outputs unresolved: waiting confirmation that we spent DELAYED_OUTPUT_TO_US (eff7682b91034395d0ff8d5d3b8d9f118e36339cf8cdfe6e840d21187ae48e83:3) using OUR_DELAYED_RETURN_TO_WALLET
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: Got new message WIRE_ONCHAIND_DEPTH
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: billboard: 1 outputs unresolved: waiting confirmation that we spent DELAYED_OUTPUT_TO_US (eff7682b91034395d0ff8d5d3b8d9f118e36339cf8cdfe6e840d21187ae48e83:3) using OUR_DELAYED_RETURN_TO_WALLET
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: Got new message WIRE_ONCHAIND_DEPTH
2025-02-28T23:00:27.281Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-onchaind-chan#1398: billboard: 1 outputs unresolved: waiting confirmation that we spent DELAYED_OUTPUT_TO_US (eff7682b91034395d0ff8d5d3b8d9f118e36339cf8cdfe6e840d21187ae48e83:3) using OUR_DELAYED_RETURN_TO_WALLET
2025-02-28T23:00:31.073Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-chan#1398: Feerate for target 885714 (-65 blocks) is 1000, fee 532sat of 1080533sat
2025-02-28T23:00:31.073Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-chan#1398: RBF onchain txid e793541cc59e9f1ec103b4f2d412a5c52ac69bce5f8c94ecaea13e2f12649ee1 (fee 532sat) with txid e793541cc59e9f1ec103b4f2d412a5c52ac69bce5f8c94ecaea13e2f12649ee1 (fee 532sat)
2025-02-28T23:00:31.073Z DEBUG   031f248d25e0ef7f7f768df6b7ba90d7a39d5ee6c36dd09aab0808c9eff9a36d39-chan#1398: RBF 02000000000101838ee47a18210d846efecdf89c33368e119f8d3b5d8dffd0954303912b68f7ef0300000000c00f000001c17a1000000000002251201e455a4ca3037e6cb8fc5b8eee47e11ff36a9711b8e6bd9be6f5de92d28c814f0347304402202079ad6d740ff15c0e5afcff02a50bb234673d1124ec5344269a6e46b9d4fa98022054a3a3dda928ebc7227070b0337c69acf95c8d928246d5cef3b011da8a472fc801004d6321034d54b4a679fb88d4420c3c307f8fc41043c3f7754e0605650d8ccca57774f6396702c00fb27521027cfa292f4d1ef6227f2c1f7f65af46667d27beb66e2218ee62c4a746b006c41268ac00000000->02000000000101838ee47a18210d846efecdf89c33368e119f8d3b5d8dffd0954303912b68f7ef0300000000c00f000001c17a1000000000002251201e455a4ca3037e6cb8fc5b8eee47e11ff36a9711b8e6bd9be6f5de92d28c814f0347304402202079ad6d740ff15c0e5afcff02a50bb234673d1124ec5344269a6e46b9d4fa98022054a3a3dda928ebc7227070b0337c69acf95c8d928246d5cef3b011da8a472fc801004d6321034d54b4a679fb88d4420c3c307f8fc41043c3f7754e0605650d8ccca57774f6396702c00fb27521027cfa292f4d1ef6227f2c1f7f65af46667d27beb66e2218ee62c4a746b006c41268ac00000000
2025-02-28T23:00:31.073Z DEBUG   lightningd: sendrawtransaction: 02000000000101838ee47a18210d846efecdf89c33368e119f8d3b5d8dffd0954303912b68f7ef0300000000c00f000001c17a1000000000002251201e455a4ca3037e6cb8fc5b8eee47e11ff36a9711b8e6bd9be6f5de92d28c814f0347304402202079ad6d740ff15c0e5afcff02a50bb234673d1124ec5344269a6e46b9d4fa98022054a3a3dda928ebc7227070b0337c69acf95c8d928246d5cef3b011da8a472fc801004d6321034d54b4a679fb88d4420c3c307f8fc41043c3f7754e0605650d8ccca57774f6396702c00fb27521027cfa292f4d1ef6227f2c1f7f65af46667d27beb66e2218ee62c4a746b006c41268ac00000000
2025-02-28T23:00:31.073Z DEBUG   hsmd: Client: Received message 28 from client
2025-02-28T23:00:31.073Z DEBUG   hsmd: Client: Received message 142 from client
2025-02-28T23:00:32.155Z **BROKEN** lightningd: FATAL SIGNAL 6 (version v25.02rc3-modded)
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: common/daemon.c:41 (send_backtrace) 0x556928d9f406
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: common/daemon.c:78 (crashdump) 0x556928d9f446
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0 ((null)) 0x7fab2e363dcf
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ../sysdeps/unix/sysv/linux/raise.c:51 (__GI_raise) 0x7fab2e363d51
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ./stdlib/abort.c:79 (__GI_abort) 0x7fab2e34d536
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ./assert/assert.c:92 (__assert_fail_base) 0x7fab2e34d40e
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ./assert/assert.c:101 (__GI___assert_fail) 0x7fab2e35c6d1
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/onchain_control.c:48 (replay_tx_hash_add) 0x556928d4e114
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/onchain_control.c:365 (replay_watch_tx) 0x556928d4e114
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/onchain_control.c:419 (replay_block) 0x556928d4e835
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/bitcoind.c:506 (getrawblockbyheight_callback) 0x556928d1c791
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/plugin.c:661 (plugin_response_handle) 0x556928d6c25a
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/plugin.c:773 (plugin_read_json_one) 0x556928d6fad3
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/plugin.c:824 (plugin_read_json) 0x556928d6fd68
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:60 (next_plan) 0x556928e5eacf
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:422 (do_plan) 0x556928e5ef5a
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:439 (io_ready) 0x556928e5f013
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ccan/ccan/io/poll.c:455 (io_loop) 0x556928e60960
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/io_loop_with_timers.c:22 (io_loop_with_timers) 0x556928d41364
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/lightningd.c:1484 (main) 0x556928d46c7a
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ../csu/libc-start.c:308 (__libc_start_main) 0x7fab2e34ed79
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x556928d1a3e9
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0xffffffffffffffff
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Mar 2, 2025
@rustyrussell
lightningd: fix crash in onchaind replay.
4225d30 
If a tx has already spent one tx we're watching, and it spends another,
we try to add it to the hash table twice, which isn't allowed:

```
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ../sysdeps/unix/sysv/linux/raise.c:51 (__GI_raise) 0x7fab2e363d51
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ./stdlib/abort.c:79 (__GI_abort) 0x7fab2e34d536
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ./assert/assert.c:92 (__assert_fail_base) 0x7fab2e34d40e
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: ./assert/assert.c:101 (__GI___assert_fail) 0x7fab2e35c6d1
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/onchain_control.c:48 (replay_tx_hash_add) 0x556928d4e114
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/onchain_control.c:365 (replay_watch_tx) 0x556928d4e114
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/onchain_control.c:419 (replay_block) 0x556928d4e835
2025-02-28T23:00:32.155Z **BROKEN** lightningd: backtrace: lightningd/bitcoind.c:506 (getrawblockbyheight_callback) 0x556928d1c791
```

Fixes: ElementsProject#8131
Reported-by: Vincenzo Palazzo
Changelog-None: introduced this release, when we banned htable dups.
Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell rustyrussell mentioned this issue Mar 2, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightningd: fix crash in onchaind replay. rustyrussell/lightning
1 participant
@vincenzopalazzo