Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the wss-proxy Python plugin with its Rust equivalent #8061

Open
ShahanaFarooqui opened this issue Feb 7, 2025 · 2 comments · May be fixed by #8080
Open

Replace the wss-proxy Python plugin with its Rust equivalent #8061

ShahanaFarooqui opened this issue Feb 7, 2025 · 2 comments · May be fixed by #8080
Labels
Highlight - UX and Dev Experience Fit and finish to make higher layer devs joyous rust Issue related to rust

Comments

@ShahanaFarooqui
Copy link
Collaborator

After the replacement of the Python clnrest plugin with Rust, only one Python plugin remains in the repository: wss-proxy.

Migrating wss-proxy to Rust also would be beneficial for:

  • Simplifying the installation process

  • Enabling a Python-free Docker image creation

  • Ensuring compatibility with NixOS

@ShahanaFarooqui ShahanaFarooqui added Highlight - UX and Dev Experience Fit and finish to make higher layer devs joyous rust Issue related to rust labels Feb 7, 2025
@daywalker90
Copy link
Contributor

Hey @ShahanaFarooqui, i have an early build working that passes the test in test_connection.py::test_wss_proxy. Is there anything else i can test this against? When multiple protocols like tls and websocket with different versions are invovled there can be problems so i want to make sure it's compatible.

@ShahanaFarooqui
Copy link
Collaborator Author

The wss-proxy plugin is relatively new, and we initially kept it lightweight, adding only a basic connection test at the time. But please feel free to add more tests as you see fit or we can expand the test coverage as the plugin matures.

@daywalker90 daywalker90 linked a pull request Feb 11, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Highlight - UX and Dev Experience Fit and finish to make higher layer devs joyous rust Issue related to rust
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants