Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutting down node due to timeout of offers plugin #7724

Closed
m-schmoock opened this issue Oct 6, 2024 · 3 comments · Fixed by #8060
Closed

Shutting down node due to timeout of offers plugin #7724

m-schmoock opened this issue Oct 6, 2024 · 3 comments · Fixed by #8060
Labels
state::needinfo
Milestone
v25.02

Comments

@m-schmoock
Copy link
Collaborator

Issue and Steps to Reproduce

I restarted my slow Raspi node. It had to reprocess servera blocks and such, the startup took longer than normal.
But when it was more or less finished (lightningd was already running normally) it shut doen by:

2024-10-06T12:33:16.408Z UNUSUAL plugin-offers: Killing plugin: timed out before replying to init
2024-10-06T12:33:16.409Z **BROKEN** plugin-offers: Plugin marked as important, shutting down lightningd!
@m-schmoock
Copy link
Collaborator Author

The issue resolved itself, after systemd restartet lightningd.
Anyway, not sure if we need to tweak something or live with the fact, that when startup takes unusually long (more than 5 mins in this case) the deamon can kill itself.

@cdecker
Copy link
Member

cdecker commented Oct 17, 2024

Any chance you could run with --log-level=io and restart? Hopefully that'd give us something to look at. Otherwise this is very hard to reproduce without having access.

@NicolasDorier NicolasDorier mentioned this issue Feb 5, 2025
Closed
@rustyrussell
Copy link
Contributor

Plugins have 60 seconds to get from us sending getmanfest, to them replying to init. This should be long enough, but perhaps in the case where a lot is happening, it is not. I'll bump the startup timer.

@rustyrussell rustyrussell added this to the v25.02 milestone Feb 7, 2025
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Feb 7, 2025
@rustyrussell
lightningd: increase startup time for plugins to 120 seconds.
488962e 
Raspberry Pi, with bitcoind running and full gossip topology may actually hit
this, and we have a report in practice.

Note that the comment is wrong, so fix that too.

Fixes: ElementsProject#7724
Reported-by: m-schmoock
Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell rustyrussell mentioned this issue Feb 7, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state::needinfo
Projects
None yet
Milestone
v25.02
Development

Successfully merging a pull request may close this issue.

lightningd: increase startup time for plugins to 120 seconds. rustyrussell/lightning
3 participants
@cdecker @rustyrussell @m-schmoock