Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpay: act on mpp feature bits #8042

Open
kilrau opened this issue Jan 29, 2025 · 2 comments · May be fixed by #8059
Open

xpay: act on mpp feature bits #8042

kilrau opened this issue Jan 29, 2025 · 2 comments · May be fixed by #8059
Milestone
v25.02

Comments

@kilrau
Copy link

kilrau commented Jan 29, 2025

We noticed xpay currently ignores feature bits 16/17 basic_mpp. It just always uses mpp. That's a real-world problem as there are still nodes in the network (e.g. Muun) which still do NOT support mpp and xpay's payments to these nodes fail.
@michael1011 michael1011 mentioned this issue Jan 29, 2025
Merged
@Lagrang3
Copy link
Collaborator

I have this on my list. Renepay also ignores that feature bit.

@rustyrussell rustyrussell added this to the v25.02 milestone Feb 4, 2025
@rustyrussell
Copy link
Contributor

OMFG wat. OK...

@rustyrussell rustyrussell linked a pull request Feb 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v25.02
Development

Successfully merging a pull request may close this issue.

xpay: don't MPP if we're told not to rustyrussell/lightning
3 participants
@rustyrussell @kilrau @Lagrang3