lightningd: Update 'listpeers' command to print alt-addrs for a peer

Author: maxrantil

contrib/msggen/msggen/schema.json

@@ -4080,6 +4080,9 @@
                 "netaddr": [
                   "127.0.0.1:40119"
                 ],
+                "alt_addrs": [
+                  "127.0.0.1:34321"
+                ],
                 "features": "08a0000a8a5961",
                 "log": [
                   {
@@ -21424,6 +21427,19 @@
                           ]
                         }
                       },
+                      "alt_addrs": {
+                        "type": "array",
+                        "description": [
+                          "An array containing zero or more alternative addresses for the peer."
+                        ],
+                        "items": {
+                          "type": "string",
+                          "description": [
+                            "Address, e.g. 1.2.3.4:1234."
+                          ]
+                        },
+                        "added": "v24.08"
+                      },
                       "remote_addr": {
                         "type": "string",
                         "description": [
@@ -21480,6 +21496,9 @@
                 "netaddr": [
                   "127.0.0.1:44619"
                 ],
+                "alt_addrs": [
+                  "127.0.0.1:34321"
+                ],
                 "features": "08a0000a0a69a2"
               }
             ]
@@ -21500,6 +21519,9 @@
                 "netaddr": [
                   "127.0.0.1:48862"
                 ],
+                "alt_addrs": [
+                  "127.0.0.1:34321"
+                ],
                 "features": "08a0000a0a69a2"
               }
             ]

doc/schemas/lightning-commando.json

@@ -147,6 +147,9 @@
             "netaddr": [
               "127.0.0.1:40119"
             ],
+            "alt_addrs": [
+              "127.0.0.1:34321"
+            ],
             "features": "08a0000a8a5961",
             "log": [
               {

doc/schemas/lightning-listpeers.json

@@ -282,6 +282,19 @@
                       ]
                     }
                   },
+                  "alt_addrs": {
+                    "type": "array",
+                    "description": [
+                      "An array containing zero or more alternative addresses for the peer."
+                    ],
+                    "items": {
+                      "type": "string",
+                      "description": [
+                        "Address, e.g. 1.2.3.4:1234."
+                      ]
+                    },
+                    "added": "v24.08"
+                  },
                   "remote_addr": {
                     "type": "string",
                     "description": [
@@ -338,6 +351,9 @@
             "netaddr": [
               "127.0.0.1:44619"
             ],
+            "alt_addrs": [
+              "127.0.0.1:34321"
+            ],
             "features": "08a0000a0a69a2"
           }
         ]
@@ -358,6 +374,9 @@
             "netaddr": [
               "127.0.0.1:48862"
             ],
+            "alt_addrs": [
+              "127.0.0.1:34321"
+            ],
             "features": "08a0000a0a69a2"
           }
         ]

lightningd/peer_control.c

@@ -2236,6 +2236,7 @@ static void json_add_peer(struct lightningd *ld,
 			  const enum log_level *ll)
 {
 	struct channel *channel;
+	struct wireaddr_internal *peer_alt_addr;
 	u32 num_channels;
 
 	json_object_start(response, NULL);
@@ -2258,6 +2259,15 @@ static void json_add_peer(struct lightningd *ld,
 					fmt_wireaddr(response, p->remote_addr));
 	}
 
+	peer_alt_addr = wallet_get_alt_addr(ld->wallet, &p->id, false);
+	if (peer_alt_addr) {
+		json_array_start(response, "alt_addrs");
+		for (size_t i = 0; i < tal_count(peer_alt_addr); i++)
+			json_add_string(response, NULL,
+				        fmt_wireaddr_internal(tmpctx, &peer_alt_addr[i]));
+		json_array_end(response);
+	}
+
 	/* Note: If !PEER_CONNECTED, peer may use different features on reconnect */
 	json_add_hex_talarr(response, "features", p->their_features);
 

tests/test_plugin.py

@@ -3707,6 +3707,13 @@ def test_sql(node_factory, bitcoind):
                          'type': 'string'},
                         {'name': 'features',
                          'type': 'hex'}]},
+        'peers_alt_addrs': {
+            'columns': [{'name': 'peer_id',
+                         'type': 'pubkey'},
+                        {'name': 'alt_addr',
+                         'type': 'string'},
+                        {'name': 'port',
+                         'type': 'u16'}]},
         'peers_netaddr': {
             'columns': [{'name': 'row',
                          'type': 'u64'},