Refactor data construction in API class to use json.dumps for better readability and security

Author: EinGuterWaran

pushbullet/pushbullet.py

@@ -1,5 +1,6 @@
 import requests
 from requests.structures import CaseInsensitiveDict
+import json
 
 
 class API():
@@ -18,7 +19,11 @@ def send_note(self, title, body):
         headers = CaseInsensitiveDict()
         headers["Access-Token"] = self.token
         headers["Content-Type"] = "application/json"
-        data = '{"body":"' + body + '","title":"' + title + '","type":"note"}'
+        data = json.dumps({
+            "body": body,
+            "title": title,
+            "type": "note"
+        })
         url = self.url + "v2/pushes"
         resp = requests.post(url, headers=headers, data=data)
         return resp
@@ -28,7 +33,12 @@ def send_link(self, title, body, url_to_send):
         headers = CaseInsensitiveDict()
         headers["Access-Token"] = self.token
         headers["Content-Type"] = "application/json"
-        data = '{"body":"' + body + '","title":"' + title + '","type":"link", "url":"' + url_to_send + '"}'
+        data = json.dumps({
+            "body": body,
+            "title": title,
+            "type": "link",
+            "url": url_to_send
+        })
         url = self.url + "v2/pushes"
         resp = requests.post(url, headers=headers, data=data)
         return resp
@@ -38,7 +48,14 @@ def send_file(self, title, body, file_name, file_type, file_url):
         headers = CaseInsensitiveDict()
         headers["Access-Token"] = self.token
         headers["Content-Type"] = "application/json"
-        data = '{"body":"' + body + '","title":"' + title + '","file_name":"' + file_name + '","file_type":"' + file_type + '","file_url":"' + file_url + '","type":"file"}'
+        data = json.dumps({
+            "body": body,
+            "title": title,
+            "file_name": file_name,
+            "file_type": file_type,
+            "file_url": file_url,
+            "type": "file"
+        })
         url = self.url + "v2/pushes"
         resp = requests.post(url, headers=headers, data=data)
         return resp