Track token-loaded state more explicitly

[swansontec]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Description

none

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1210632586279103

[cursor]

Bug: Incorrect Token Removal Detection

The onNewTokens callback incorrectly logs "removed" tokens. The removed variable is calculated as whatsNew(detectedTokenIds, tokenIds). Since tokenIds represents only the newly detected tokens from the current callback invocation, and detectedTokenIds represents all currently detected tokens, this calculation incorrectly identifies existing detected tokens (those not in the current new batch) as "removed." This is misleading as onNewTokens is an add-only callback, and no tokens are actually removed from the wallet's detected list. The variable name removed is therefore inaccurate and confusing.

src/core/currency/wallet/currency-wallet-callbacks.ts#L142-L147

edge-core-js/src/core/currency/wallet/currency-wallet-callbacks.ts

Lines 142 to 147 in b553d95

	// Logging:
	const added = whatsNew(tokenIds, detectedTokenIds)
	const removed = whatsNew(detectedTokenIds, tokenIds)
	const shortId = walletId.slice(0, 2)
	input.props.log.warn(
	`enabledTokenIds: ${shortId} engine detected tokens, add [${added}], remove [${removed}]`

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎