Fix syncing races between periodic and change-server syncing

[samholmes]

This fixes the race between periodic syncing and change-server subscriptions by introducing a usesChangeServer flag on EdgeCurrencyInfo which tells the core to not invoke periodic syncing.

In addition, we introduce a resubscribing state to the subscription status to differentiate initial subscription with intermittent subscription issues from the change server.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Description

none

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1210744859078593

[samholmes]

Bug: Subscription Status Overwrite Bug

The subscription status update logic incorrectly applies the same status to all subscriptions in a wallet, instead of updating each individual subscription based on its specific result. The status determined for a single subscription's outcome is then mapped to all subscriptions for that wallet, overwriting existing correct statuses (e.g., 'listening') with potentially incorrect ones (e.g., 'resubscribing'). If a wallet has multiple subscriptions with varied outcomes, the status from the last processed result will be applied to all.

src/core/currency/currency-pixie.ts#L302-L310

edge-core-js/src/core/currency/currency-pixie.ts

Lines 302 to 310 in e39f343

	// Update the status for the subscription:
	const subscriptions = wallet.changeServiceSubscriptions.map(
	subscription => ({
	...subscription,
	status
	})
	)
	subscriptionUpdates.set(walletId, subscriptions)

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

This is indeed true, however this is because most wallets will have a single subscription

[cursor]

Bug: Wallet Status Overwritten by Last Subscription

The subscription status update logic incorrectly applies a single determined status to all subscriptions within a wallet, rather than updating each individually. This bug was introduced by removing a filter that previously limited updates to 'subscribing' statuses. Now, the status derived from a single subscription's outcome is mapped to all subscriptions in the wallet, overwriting correct statuses (e.g., 'listening') with potentially incorrect ones (e.g., 'avoiding', 'resubscribing'). If a wallet has multiple subscriptions, the final status for all is determined by the last processed subscription's result.

src/core/currency/currency-pixie.ts#L302-L311

edge-core-js/src/core/currency/currency-pixie.ts

Lines 302 to 311 in e39f343

	// Update the status for the subscription:
	const subscriptions = wallet.changeServiceSubscriptions.map(
	subscription => ({
	...subscription,
	status
	})
	)
	subscriptionUpdates.set(walletId, subscriptions)
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎