Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSubtitles Direct Downloads: Support direct links in search listings #2

Open
ntzb opened this issue Feb 17, 2017 · 6 comments
Open

Comments

@ntzb
Copy link

ntzb commented Feb 17, 2017

doesn't work.. downloads a .htm file along with a .exe file

@Ede123
Copy link
Owner

Ede123 commented Feb 17, 2017

Do you mind telling me which userscript this is about?

@ntzb
Copy link
Author

ntzb commented Feb 17, 2017

sorry. I meant the opensubtitles direct download one.

@Ede123
Copy link
Owner

Ede123 commented Feb 18, 2017

OK thanks.

Are you using the most recent version? I just recently pushed version 1.1 (see 7461287) which fixed such an issue.

Seems OpenSubtitles is now actively trying to prevent direct downloads, but a quick test just now worked fine for me...

@Ede123
Copy link
Owner

Ede123 commented Feb 18, 2017

Oh, and are you using an add-blocker?
OpenSuptitles recently added some nasty advertisement that sometimes will open when clicking anywhere on the page but that is usually suppressed by add-blockers (e.g. uBlock origin).

@ntzb
Copy link
Author

ntzb commented Feb 18, 2017

Hi, sorry for being vague.
I will try to be as clear as I can:

  1. I didn't see the update.
  2. after using the updated userscript, going into the webpage of a specific subtitle, where you can see the "thanks" and "download" button, clicking download IS directly downloading.
  3. when viewing a list of subtitles, and you see a chart with the download column, clicking the download button (that button that says for example - "63x srt") isn't directly downloading, and sends you to that "You will get subtitles from OpenSubtitles.org soon. Support us and get instant download" page. I thought it was suppose to work there too?

thanks!!

@Ede123
Copy link
Owner

Ede123 commented Feb 18, 2017

No, actually it's only designed to work with the "Download" button.

I checked if it is possible to adjust the script for those links, too, but there is no good way. As I can't extract the direct download link from the page the only possibility would be to follow the link (i.e. open the unwanted page in background) and extract the actual location of the subtitle file from there.

I'll consider this for the future but right now I suggest to work around the issue by expanding the entry in the list and use the "Download" button there...

@Ede123 Ede123 changed the title doesn't work.. downloads a .htm file along with a .exe file OpenSubtitles Direct Downloads: Support direct links in search listings Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants