Skip to content

Commit d387ff6

Browse files
authoredDec 20, 2023
Merge pull request #318 from EasyPost/fix_regenerate_rates_type
fix regenerate rates type
2 parents 7484869 + ed631c8 commit d387ff6

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed
 

‎CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# CHANGELOG
22

3+
## v9.0.1 (2023-12-20)
4+
5+
- Corrects the return type of `regenerate_rates`
6+
37
## v9.0.0 (2023-12-06)
48

59
See our [Upgrade Guide](UPGRADE_GUIDE.md#upgrading-from-8x-to-90) for more details.

‎easypost/services/shipment_service.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def get_next_page(
7272

7373
return self.all(**params)
7474

75-
def regenerate_rates(self, id: str) -> Shipment:
75+
def regenerate_rates(self, id: str) -> Dict[str, List[Rate]]:
7676
"""Regenerate Rates for a Shipment."""
7777
url = f"{self._instance_url(self._model_class, id)}/rerate"
7878

‎easypost/util.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
Dict,
88
List,
99
Optional,
10+
Union,
1011
)
1112

1213
from easypost.constant import (
@@ -24,14 +25,15 @@
2425
InvalidParameterError,
2526
SignatureVerificationError,
2627
)
28+
from easypost.models.rate import Rate
2729

2830

2931
def get_lowest_object_rate(
30-
easypost_object: EasyPostObject,
32+
easypost_object: Union[EasyPostObject, Dict[str, Any]],
3133
carriers: Optional[List[str]] = None,
3234
services: Optional[List[str]] = None,
3335
rates_key: str = "rates",
34-
):
36+
) -> Rate:
3537
"""Gets the lowest rate of an EasyPost object such as a Shipment, Order, or Pickup."""
3638
carriers = carriers or []
3739
services = services or []
@@ -53,7 +55,7 @@ def get_lowest_object_rate(
5355
return lowest_rate
5456

5557

56-
def get_lowest_smart_rate(smart_rates, delivery_days: int, delivery_accuracy: str):
58+
def get_lowest_smart_rate(smart_rates: List[Rate], delivery_days: int, delivery_accuracy: str) -> Rate:
5759
"""Get the lowest SmartRate from a list of SmartRates."""
5860
valid_delivery_accuracy_values = {
5961
"percentile_50",

0 commit comments

Comments
 (0)
Please sign in to comment.