- Linting and static analysis

Author: nwithan8

EasyPost.Tests/ServicesTests/Beta/CarrierMetadataServiceTest.cs

@@ -47,12 +47,12 @@ public async Task TestRetrieve()
         public async Task TestRetrieveWithFilters()
         {
             UseVCR("retrieve_with_filters");
-            
+
             const string carrierName = "usps";
 
             BetaFeatures.Parameters.Beta.CarrierMetadata.Retrieve parameters = new()
             {
-                Carriers =  new List<string> { carrierName },
+                Carriers = new List<string> { carrierName },
                 Types = new List<CarrierMetadataType> { CarrierMetadataType.ServiceLevels, CarrierMetadataType.PredefinedPackages },
             };
 

EasyPost/BetaFeatures/Parameters/Beta/CarrierMetadata/Retrieve.cs

@@ -12,32 +12,32 @@ namespace EasyPost.BetaFeatures.Parameters.Beta.CarrierMetadata
     public sealed class Retrieve : BaseParameters
     {
         #region Request Parameters
-        
+
         /// <summary>
         ///     A list of carrier names to retrieve metadata for.
         /// </summary>
         public List<string>? Carriers { get; set; }
-        
+
         /// <summary>
         ///     A list of metadata types to retrieve.
         /// </summary>
         public List<CarrierMetadataType>? Types { get; set; }
 
         #endregion
-        
+
         /// <summary>
         ///     Override the default <see cref="BaseParameters.ToDictionary"/> method to handle the unique serialization requirements for this parameter set.
         /// </summary>
         /// <returns>A <see cref="Dictionary{TKey,TValue}"/>.</returns>
         internal override Dictionary<string, object> ToDictionary()
         {
             Dictionary<string, object> data = new();
-            
+
             if (Carriers != null)
             {
                 data.Add("carriers", string.Join(",", Carriers));
             }
-            
+
             if (Types != null)
             {
                 data.Add("types", string.Join(",", Types.Select(x => x.ToString())));

EasyPost/Utilities/Internal/Attributes/BaseCustomAttribute.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Reflection;
 
 namespace EasyPost.Utilities.Internal.Attributes
@@ -20,7 +19,7 @@ internal static IEnumerable<PropertyInfo> GetPropertiesWithAttribute<T>(Type @ty
             {
                 object[] attributes = property.GetCustomAttributes(typeof(T), true);
 
-                if (attributes.Any())
+                if (attributes.Length > 0)
                 {
                     matchingProperties.Add(property);
                 }
@@ -46,7 +45,7 @@ internal static IEnumerable<MethodInfo> GetMethodsWithAttribute<T>(Type @type)
             {
                 object[] attributes = method.GetCustomAttributes(typeof(T), true);
 
-                if (attributes.Any())
+                if (attributes.Length > 0)
                 {
                     matchingMethods.Add(method);
                 }

EasyPost/Utilities/Internal/JsonSerialization.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Dynamic;
-using System.Linq;
 using EasyPost.Exceptions.General;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
@@ -56,7 +55,7 @@ internal static T ConvertJsonToObject<T>(string? data, JsonSerializerSettings? j
         // ReSharper disable once MemberCanBePrivate.Global
         internal static object ConvertJsonToObject(string? data, Type type, JsonSerializerSettings? jsonSerializerSettings = null, List<string>? rootElementKeys = null)
         {
-            if (rootElementKeys != null && rootElementKeys.Any())
+            if (rootElementKeys is { Count: > 0 })
             {
                 data = GoToRootElement(data, rootElementKeys);
             }