Fix EvseId 0 not throwing the correct exception (#799)

marcemmers · web-flow · commit 8124039f823b · 2024-09-19T10:23:55.000+02:00
Signed-off-by: Marc Emmers &lt;m.emmers@alfen.com&gt;
diff --git a/lib/ocpp/v201/evse_manager.cpp b/lib/ocpp/v201/evse_manager.cpp
@@ -30,14 +30,14 @@ EvseManager::EvseIterator EvseManager::end() {
 }
 
 EvseInterface& EvseManager::get_evse(int32_t id) {
-    if (id > this->evses.size()) {
+    if (id == 0 or id > this->evses.size()) {
         throw EvseOutOfRangeException(id);
     }
     return *this->evses.at(id - 1);
 }
 
 const EvseInterface& EvseManager::get_evse(int32_t id) const {
-    if (id > this->evses.size()) {
+    if (id == 0 or id > this->evses.size()) {
         throw EvseOutOfRangeException(id);
     }
     return *this->evses.at(id - 1);

Original file line number	Diff line number	Diff line change
`@@ -30,14 +30,14 @@ EvseManager::EvseIterator EvseManager::end() {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`EvseInterface& EvseManager::get_evse(int32_t id) {`
`33`		`- if (id > this->evses.size()) {`
	`33`	`+ if (id == 0 or id > this->evses.size()) {`
`34`	`34`	`throw EvseOutOfRangeException(id);`
`35`	`35`	`}`
`36`	`36`	`return *this->evses.at(id - 1);`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`const EvseInterface& EvseManager::get_evse(int32_t id) const {`
`40`		`- if (id > this->evses.size()) {`
	`40`	`+ if (id == 0 or id > this->evses.size()) {`
`41`	`41`	`throw EvseOutOfRangeException(id);`
`42`	`42`	`}`
`43`	`43`	`return *this->evses.at(id - 1);`