Merge pull request #12 from EGAMAGZ/development

Fixed unexpected behaviour when no duration is passed for an easter egg

Author: EGAMAGZ

deno.json

@@ -1,6 +1,6 @@
 {
   "name": "@egamagz/paska-ovo",
-  "version": "1.0.6",
+  "version": "1.0.7",
   "exports": "./mod.ts",
   "lock": false,
   "compilerOptions": {

src/paska-ovo.ts

@@ -7,6 +7,7 @@
 
 import type { Callback, EasterEgg, EasterEggState } from "./types.ts";
 import { codeToChars } from "./util/code.ts";
+import { DEFAULT_DURATION } from "./util/constants.ts";
 import { isInputElement } from "./util/dom.ts";
 
 /**
@@ -162,14 +163,10 @@ export class PaskaOvo {
       this.callbacks.forEach((callback) => callback(easterEgg));
 
       if (easterEgg.onFinish) {
-        if (easterEgg.duration) {
-          setTimeout(
-            easterEgg.onFinish,
-            easterEgg.duration,
-          );
-        } else {
-          easterEgg.onFinish();
-        }
+        setTimeout(
+          easterEgg.onFinish,
+          easterEgg.duration || DEFAULT_DURATION,
+        );
       }
     } catch (error) {
       console.error(`Error executing easter egg ${easterEgg.tag}:`, error);

src/util/constants.ts

@@ -30,3 +30,5 @@ export const INPUT_ELEMENTS = [
   "input",
   "select",
 ];
+
+export const DEFAULT_DURATION = 1_000;