Skip to content

Commit 225be90

Browse files
authored
Merge pull request #137 from EFUB5-RoomListener/revert-132-develop
Revert "[Deploy] 방 내부 사용자 조회 반영"
2 parents fe2dd64 + e0fecea commit 225be90

5 files changed

Lines changed: 2 additions & 68 deletions

File tree

mavve/src/main/java/com/efub/mavve/room/controller/RoomController.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,6 @@ public ResponseEntity<RoomEnterResponse> getRoomEnterInfo(@PathVariable("roomId"
111111
return ResponseEntity.ok(response);
112112
}
113113

114-
// 방 내부 사용자 조회
115-
@GetMapping("/{roomId}/users")
116-
public ResponseEntity<RoomUserResponse> getUserInRoom(@PathVariable("roomId") Long roomId){
117-
RoomUserResponse response = roomService.getUserInRoom(roomId);
118-
return ResponseEntity.ok(response);
119-
}
120-
121114
// 방에 플레이리스트 추가
122115
@PostMapping("/{roomId}/playlists")
123116
public void addPlaylistInRoom(@PathVariable("roomId") Long roomId,

mavve/src/main/java/com/efub/mavve/room/dto/response/RoomUserResponse.java

Lines changed: 0 additions & 23 deletions
This file was deleted.

mavve/src/main/java/com/efub/mavve/room/dto/summary/RoomUserSummary.java

Lines changed: 0 additions & 22 deletions
This file was deleted.

mavve/src/main/java/com/efub/mavve/room/service/RoomService.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.efub.mavve.room.service;
22

33
import com.efub.mavve.auth.domain.User;
4-
import com.efub.mavve.auth.repository.UserRepository;
54
import com.efub.mavve.global.exception.ExceptionCode;
65
import com.efub.mavve.global.exception.MavveException;
76
import com.efub.mavve.room.domain.Room;
@@ -12,8 +11,6 @@
1211
import com.efub.mavve.room.dto.response.RoomEnterResponse;
1312
import com.efub.mavve.room.dto.response.RoomListResponse;
1413
import com.efub.mavve.room.dto.response.RoomResponse;
15-
import com.efub.mavve.room.dto.response.RoomUserResponse;
16-
import com.efub.mavve.room.dto.summary.RoomUserSummary;
1714
import com.efub.mavve.room.payload.summary.CurrentSongSummary;
1815
import com.efub.mavve.room.payload.summary.SongRedis;
1916
import com.efub.mavve.room.repository.RoomRepository;
@@ -41,7 +38,6 @@ public class RoomService {
4138
private final RoomSongService roomSongService;
4239
private final RoomPlaylistService roomPlaylistService;
4340
private final RoomLikeRepository roomLikeRepository;
44-
private final UserRepository userRepository;
4541

4642
// 방 생성
4743
@Transactional
@@ -226,14 +222,4 @@ private String getTotalDurationTime(List<SongRedis> songs){
226222
else if (minutes > 0) return String.format("%d분 %d초", minutes, seconds);
227223
else return String.format("%d초", seconds);
228224
}
229-
230-
public RoomUserResponse getUserInRoom(Long roomId) {
231-
List<String> userIds = roomUserRedisService.getAllUsers(roomId);
232-
List<RoomUserSummary> users = userIds.stream().map(userId -> {
233-
User user = userRepository.findByUserId(Long.parseLong(userId))
234-
.orElseThrow(() -> new MavveException(ExceptionCode.USER_NOT_FOUND));
235-
return RoomUserSummary.from(user);
236-
}).collect(Collectors.toList());
237-
return RoomUserResponse.from(users);
238-
}
239225
}

mavve/src/main/java/com/efub/mavve/room/service/redis/RoomUserRedisService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ public boolean hasUsers(Long roomCode){
4040
}
4141

4242
// 현재 방에 남이있는 사용자 전체 조회
43-
public List<String> getAllUsers(Long roomCode) {
43+
private List<String> getAllUsers(Long roomCode) {
4444
String key = RoomRedisKeyUtils.getUserListKey(roomCode);
4545
List<String> userList = stringRedisTemplate.opsForList().range(key, 0, -1);
4646

47-
if(userList == null || userList.isEmpty()) return Collections.emptyList();
47+
if(userList == null) return Collections.emptyList();
4848
return userList;
4949
}
5050

0 commit comments

Comments
 (0)