Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i#7275: decode/x86 decode xbegin/xabort more strictly. #7311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

i#7275: decode/x86 decode xbegin/xabort more strictly. #7311

wants to merge 1 commit into from
+83 −49

Conversation

khuey
Copy link
Contributor

@khuey khuey commented Mar 1, 2025

XBEGIN/ABORT are accepted only if their modrm byte is f8. Filter out other previously modrm bytes by introducing the necessary decode table entries to filter on the mod and rm fields in addition to the reg field.

Fixes #7275

@khuey
i#7275: decode/x86 decode xbegin/xabort more strictly.
2cd4a45 
XBEGIN/ABORT are accepted only if their modrm byte is f8. Filter out other previously modrm bytes by introducing the necessary decode table entries to filter on the mod and rm fields in addition to the reg field.

Fixes #7275
@khuey
Copy link
Contributor Author

khuey commented Mar 1, 2025

I will say that I don't really understand the changes in the dis test. Are those code files randomly generated?

@khuey khuey requested a review from derekbruening March 1, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbruening derekbruening Awaiting requested review from derekbruening

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DR decoder incorrectly thinks c7 ff ff ff ff 56 is a valid XBEGIN encoding
1 participant
@khuey