Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make English default resource #348

Open
takahirom opened this issue Sep 10, 2022 · 9 comments
Open

Make English default resource #348

takahirom opened this issue Sep 10, 2022 · 9 comments

Comments

@takahirom
Copy link
Member

takahirom commented Sep 10, 2022

Idea Description
When non-Japanese and non-English speakers look at the DroidKaigi app, they will see the Japanese texts currently. But English is more friendly for most people. So I think it is appropriate to use English as the default resource.

Reference images and links
Remove values-en and add values-ja for all resources.

I think we can do it like this.

mkdir values-ja
mv values/strings.xml values-ja
mv values-en/strings.xml values/
@omooooori
Copy link

🙋

@takahirom
Copy link
Member Author

Thanks! Assigned!

@takahirom
Copy link
Member Author

@omooooori Are you OK? How's it going?

@att55
Copy link
Contributor

att55 commented Sep 25, 2022

@takahirom Is the priority of this issue high?

@takahirom
Copy link
Member Author

I think It's not very high.

@att55
Copy link
Contributor

att55 commented Sep 25, 2022

OK 🙆🏼‍♂️
Thanks for your reply.

@omooooori
Copy link

@takahirom I'm sorry for the late response. I am now working on this task.
Currently, there is MR package in core>model>src>commonMain>resources.
In MR package, there are base, en, zh packages.

And there is StringResource.kt for localize application.

I changed my phone's system language to English and open this app.
I could see that English is shown in the app.
So I think current app does not needs to make English as default resources.

@takahirom
Copy link
Member Author

takahirom commented Oct 4, 2022

@omooooori This is not for English users. For example, when Korean users that are not familiar with Japanese open the app, they will see a Japanese screen due to the default setting. But Japanese is not as famous a language as English. So I would like to make English default language. What do you think?

@omooooori
Copy link

@takahirom I see. I understand. I will consider the solution of this task.
Currently, there is MR package in core>model>src>commonMain>resources.
So I think we can't fulfill the requirement using the solution written in initial description, is this right ?

I mean initial description is below.

Idea Description
When non-Japanese and non-English speakers look at the DroidKaigi app, they will see the Japanese texts currently. But English is more friendly for most people. So I think it is appropriate to use English as the default resource.
Reference images and links
Remove values-en and add values-ja for all resources.
I think we can do it like this.
mkdir values-ja
mv values/strings.xml values-ja
mv values-en/strings.xml values/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants