Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add individual hyper enchanting limit config options #78

Open
RubyCascade opened this issue Dec 4, 2024 · 2 comments
Open

Add individual hyper enchanting limit config options #78

RubyCascade opened this issue Dec 4, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@RubyCascade
Copy link

Describe the your request

Add the ability to set hyper enchanting limits for individual enchantments. This is important especially for modded enchantments because allowing it to be set over the intended amount can be very broken, for example with a lifesteal enchantment you could end up in a situation where you're healed for 120% of the damage dealt. Another example is unbreaking, at level 5 whatever tool it is applied to becomes fully unbreakable, this can be problematic with modded items that need to break for balancing purposes.

I will give an example of how the configuration of this could be set up, +1 for unbreaking and disabled for mending. (I will be using JSON for the example because I'm more familiar with it than TOML)

{
    "IndividualHyperenchantLimits": {
        "minecraft:unbreaking": 1,
        "minecraft:mending": 0
}
@RubyCascade RubyCascade added the enhancement New feature or request label Dec 4, 2024
@RubyCascade
Copy link
Author

If it's too much to add that then just adding a blacklist would also be an acceptable solution. For example

{
    "HyperenchantingBlacklist": [
        "minecraft:unbreaking",
        "minecraft:mending"
    ]
}

@RubyCascade
Copy link
Author

Also, adding configurable hyperenchanting cost modifiers (multiplicative) would be extremely helpful for balancing as well. For example

{
    "HyperenchantingCostMod": {
        "minecraft:unbreaking": 1.5,
        "minecraft:mending": 2.0
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant