From bebad07c18925a8761e6c1db7807d5a133610f59 Mon Sep 17 00:00:00 2001 From: Danny Shoun Date: Fri, 10 Nov 2023 07:58:10 -0700 Subject: [PATCH 1/2] Fix switch case for Sturdy Shovel BOD reward. --- data/js/npc/ai/vendor_bdo_dispenser.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/data/js/npc/ai/vendor_bdo_dispenser.js b/data/js/npc/ai/vendor_bdo_dispenser.js index 9e453a24a..79e849be9 100644 --- a/data/js/npc/ai/vendor_bdo_dispenser.js +++ b/data/js/npc/ai/vendor_bdo_dispenser.js @@ -694,17 +694,17 @@ function DispenseBODRewards( pDropper, npcDroppedOn, iDropped ) minReward = 0 + minMaxMod[0]; maxReward = 16 + minMaxMod[1]; - switch( WeightedRandom( minReward, maxReward, weightVal )) + switch( WeightedRandom( minReward, maxReward, weightVal ) ) { case 0: // Sturdy Pickaxe / Sturdy Shovel (equal chance) - switch( RandomNumber( 0, 1 )) + switch( RandomNumber( 0, 1 ) ) { case 0: // Sturdy Pickaxe bodRewardItem = CreateBODReward( 0, socket, pDropper, 0 ); break; case 1: // Sturdy Shovel - break; bodRewardItem = CreateBODReward( 1, socket, pDropper, 0 ); + break; default: break; } From 62dc86ff2f23fc347801a1d6d9fbbb378ca7f8d8 Mon Sep 17 00:00:00 2001 From: Danny Shoun Date: Fri, 10 Nov 2023 09:27:50 -0700 Subject: [PATCH 2/2] Modify effective skills instead of base skills with boost items. --- data/js/item/equip_effects/skill_boosting_equipment.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/data/js/item/equip_effects/skill_boosting_equipment.js b/data/js/item/equip_effects/skill_boosting_equipment.js index 7fa391fd1..641e56b94 100644 --- a/data/js/item/equip_effects/skill_boosting_equipment.js +++ b/data/js/item/equip_effects/skill_boosting_equipment.js @@ -21,10 +21,10 @@ function onEquip( pEquipper, iEquipped ) switch( skillBonusID ) { case 7: // Blacksmithing - pEquipper.baseskills.blacksmithing += skillBonusVal; + pEquipper.skills.blacksmithing += skillBonusVal; break; case 45: // Mining - pEquipper.baseskills.mining += skillBonusVal; + pEquipper.skills.mining += skillBonusVal; break; default: break; @@ -39,10 +39,10 @@ function onUnequip( pUnquipper, iUnequipped ) switch( skillBonusID ) { case 7: // Blacksmithing - pUnquipper.baseskills.blacksmithing -= skillBonusVal; + pUnquipper.skills.blacksmithing -= skillBonusVal; break; case 45: // Mining - pUnquipper.baseskills.mining -= skillBonusVal; + pUnquipper.skills.mining -= skillBonusVal; break; default: break;