fix(datepicker): fixed chrome crashed bug by scrollList aria prop #2722 #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cf18bf3:
|
semi-design
|
||||||||||||||||||||||||||||||
| Project |
semi-design
|
| Branch Review |
fix/scroll-aria-crash
|
| Run status |
|
| Run duration | 08m 02s |
| Commit |
|
| Committer | Shi Jia |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
11
|
Skipped
|
0
|
Passing
|
279
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Tests for review
semi-design
|
||||||||||||||||||||||||||||||
| Project |
semi-design
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 08m 21s |
| Commit |
|
| Committer | Shi Jia |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
2
|
|
Flaky
|
0
|
|
Pending
|
11
|
|
Skipped
|
0
|
|
Passing
|
279
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Tests for review
|
有2个 cypress 用例挂了，符合预期，aria-selected 被注释了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
Fixes #2722
Changelog
🇨🇳 Chinese
🇺🇸 English
Checklist
Other
Additional information