Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a new selector type for the hover style fallback in the renderWrapper scenario #2691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YannLynn
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2690

Changelog

🇨🇳 Chinese

  • Fix: Nav 新增选择器样式为 renderWrapper 场景提供 hover 样式

🇺🇸 English

  • Fix: Nav adds a new selector style to provide hover style for renderWrapper scenes

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@YannLynn YannLynn requested a review from YyumeiZhang January 26, 2025 09:23
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f59b77b:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Jan 26, 2025

semi-design    Run #3056

Run Properties:  status check passed Passed #3056  •  git commit 9011258478 ℹ️: Merge f59b77bd98cd0a429b3c6db7c348552950f20eb2 into df507ba206eeb6647e4e1029cbcb...
Project semi-design
Branch Review fix-2690
Run status status check passed Passed #3056
Run duration 08m 00s
Commit git commit 9011258478 ℹ️: Merge f59b77bd98cd0a429b3c6db7c348552950f20eb2 into df507ba206eeb6647e4e1029cbcb...
Committer YannLynn
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 281
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎


// 兼容 renderWrapper 的场景,详见 issue: https://github.com/DouyinFE/semi-design/issues/2690
&-list .#{$module}-sub-wrap {
& > .#{$module}-sub-title {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否需要考虑 disabled 的场景呢?看上面的 scss 中是有 disabled 的场景

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation] Nav renderWrapper has not hover style in Nav.Sub
2 participants