Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : CommentDslDto 삭제 후 CommentDto로 통합 #145

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix : CommentDslDto 삭제 후 CommentDto로 통합 #145

merged 1 commit into from
Apr 29, 2024

Conversation

peter-jaesungyu
Copy link

@peter-jaesungyu peter-jaesungyu commented Apr 27, 2024 •
edited
Loading

관련 이슈

변경사항

  • DslDto에서 Dto로 일괄 통일하기로 합의함에 따라, CommentDslDto 내 코드를 CommentDto으로 이동하였습니다.
  • DTO와 DTO 간 이동 외 코드의 변화 없습니다.
  • Comment 관련 unused import 등 정리하였습니다.
  • 대댓글 기능 확인 완료하였습니다.

Postman 확인 결과

  • getComments
    image

@peter-jaesungyu peter-jaesungyu added the fix fix code label Apr 27, 2024
@peter-jaesungyu peter-jaesungyu self-assigned this Apr 27, 2024
@peter-jaesungyu peter-jaesungyu linked an issue Apr 27, 2024 that may be closed by this pull request
CommentDslDto 변경 #144
Open
minnieming
minnieming approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@minnieming minnieming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

kyungmin1221
kyungmin1221 approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@kyungmin1221 kyungmin1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

juwum12
juwum12 approved these changes Apr 29, 2024
View reviewed changes
Copy link

@juwum12 juwum12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@peter-jaesungyu peter-jaesungyu merged commit 47c3006 into develop Apr 29, 2024
@peter-jaesungyu peter-jaesungyu deleted the feature/144/commentDslDto branch April 29, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungmin1221 kyungmin1221 kyungmin1221 approved these changes

@juwum12 juwum12 juwum12 approved these changes

@minnieming minnieming minnieming approved these changes

Assignees

@peter-jaesungyu peter-jaesungyu

Labels
fix fix code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommentDslDto 변경
4 participants
@peter-jaesungyu @kyungmin1221 @juwum12 @minnieming