Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter Github action broken if not on pull request #531

Closed
2 tasks
pawel-kow opened this issue May 10, 2024 · 2 comments
Closed
2 tasks

Linter Github action broken if not on pull request #531

pawel-kow opened this issue May 10, 2024 · 2 comments
Labels
bug

Comments

@pawel-kow
Copy link
Member

Status is needed on a merge queue, so merge_group trigger had to be added.
But then everything falls apart as this is not a pull request.
See https://github.com/Domain-Connect/Templates/actions/runs/9030009240

  • changed files are not recognised and version check is not working (incorrect references)
  • commenting PR does not work (obviously)
@pawel-kow pawel-kow added the bug label May 10, 2024
@pawel-kow
Copy link
Member Author

For time being disabled this check as required.

pawel-kow added a commit that referenced this issue May 10, 2024
@pawel-kow
BUGFIX: #531 correct linter run for both pull request and merge queue
6885e91
@pawel-kow
Copy link
Member Author

Fixed with 6885e91
Tested with PRs #532 and #533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pawel-kow