-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew autoupdate version
returns stale data
#130
Comments
autoupdate version
is returning old version and old "last changed"brew autoupdate version
returns stale data
Thank you for this issue. This annoys me as well. The last time I developed a new feature, my PR just got merged, without any questions or hints from the maintainers regarding version increase and commit message. Maybe something like a |
This has been updated:
I do apologise that this tap has various amounts of love poured into it at wildly different times. I sort of consider the tap close to feature complete, and consequently have skimmed down the amount of things I want to expand the tap into doing, or changing behaviours in significant ways without really solid justification. In the past, every x number of commits I'd manually create a PR that bumps the version and triggers the new changelog. This wasn't really a problem because for the most part I was the only person changing anything 😄. In theory the versioning loosely follows semantic versioning and the versioning sort of exists because functionality was always intended to be removed (for example, using anything other than the now native notifier applet for notifications), and I appreciated the chance of this breaking people's workflows and wanting to give them something tangible to see this coming with. The other slight issue is that the script once created is not periodically recreated, so there had to be some mechanism to essentially get people to |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Hey,
awesome extension!
I noticed that the
version
subcommand is returning stale data.On the latest commit on the master HEAD i still get commits made in 2022:
Solution
It seems that at some point the release notes mechanism was abandoned and the "Last Changed" has remained hardcoded in
lib/autoupdate/version.rb
:https://github.com/Homebrew/homebrew-autoupdate/blob/master/lib/autoupdate/version.rb#L34-L36
We should probably change the grep and maybe drop the version information since there doesn't seem to be a version published anymore :)
Why it might be a problem?
I was very confused since I tried to update the "autoupdate" command and version was returning the 2022 date constantly, only after I manually checked my git log was I assured that it actually updated.
The text was updated successfully, but these errors were encountered: