Use custom reward address in mnvaults.py.

Custom reward addresses are one of the core features needed for
proper masternode vaults.  With them implemented now, we can update
the mnvaults.py test (resolving two FIXME's in there) to actually make
use of an explicit reward address so that the masternode rewards are
received and not lost (as we want them to be in practice).

Author: domob1812

divi/qa/rpc-tests/mnvaults.py

@@ -1,5 +1,5 @@
 #!/usr/bin/env python3
-# Copyright (c) 2020 The DIVI developers
+# Copyright (c) 2020-2021 The DIVI developers
 # Distributed under the MIT/X11 software license, see the accompanying
 # file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
@@ -31,6 +31,7 @@ def __init__ (self):
     self.cfg = None
 
   def setup_chain (self):
+    print("Initializing test directory " + self.options.tmpdir)
     for i in range (7):
       initialize_datadir (self.options.tmpdir, i)
 
@@ -78,7 +79,7 @@ def start_node (self, n):
       args.append ("-masternodeprivkey=%s" % self.cfg.privkey)
 
     if self.cfg:
-      cfg = [self.cfg.line]
+      cfg = [self.cfg.getLine ()]
     else:
       cfg = []
 
@@ -153,8 +154,7 @@ def fund_vault (self):
 
     self.cfg = fund_masternode (self.nodes[0], "mn", "copper", txid,
                                 "localhost:%d" % p2p_port (1))
-    # FIXME: Use reward address from node 0.
-    self.cfg.rewardAddr = addr
+    self.cfg.rewardAddr = self.nodes[0].getnewaddress ("reward")
 
     for i in [0, 2]:
       self.stop_node (i)
@@ -233,6 +233,9 @@ def get_payments (self):
       self.advance_time (10)
       time.sleep(0.01)
 
+    # Mine some blocks normally to make sure the rewards are mature.
+    self.mine_blocks (20)
+
     # Check that some payments were made.
     winners = self.nodes[3].getmasternodewinners ()
     found = False
@@ -242,7 +245,9 @@ def get_payments (self):
         break
     assert_equal (found, True)
 
-    # FIXME: Check in wallet when we have a custom reward address.
+    # The payments should have been received at the reward address
+    # and in particular not be lost in the "destroyed" vault.
+    assert_greater_than (self.nodes[0].getbalance ("reward"), 0)
 
   def unvault (self):
     print ("Unvaulting the funds...")