Skip to content

Commit 85f6c4a

Browse files
committed
v1.1.1 Fixed Default Error
- Fixed an issue where an error would occur if the default value of a float was below 0 or above 1. - Intergers can now throw an error if the default value is not between minimum and maximum range
1 parent b0fbf3b commit 85f6c4a

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

DistanceModConfigurationManager/DistanceGUI/Controls/FloatSlider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public FloatSlider WithDefaultValue(float defaultValue)
2020
{
2121
if (defaultValue > Maximum || defaultValue < Minimum)
2222
{
23-
throw new ArgumentOutOfRangeException("Default value must be between minimum and maximum values.");
23+
throw new ArgumentOutOfRangeException($"Default value ({defaultValue}) must be between minimum ({Minimum}) and maximum ({Maximum}) values.");
2424
}
2525

2626
DefaultValue = defaultValue;

DistanceModConfigurationManager/DistanceGUI/Controls/IntegerSlider.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ public IntegerSlider WithSetter(Action<int> setter)
2828
}
2929
public IntegerSlider WithDefaultValue(int defaultValue)
3030
{
31+
if (defaultValue > Maximum || defaultValue < Minimum)
32+
{
33+
throw new ArgumentOutOfRangeException($"Default value ({defaultValue}) must be between minimum ({Minimum}) and maximum ({Maximum}) values.");
34+
}
35+
3136
DefaultValue = defaultValue;
3237
return this;
3338
}

DistanceModConfigurationManager/Plugin.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public sealed class Mod : BaseUnityPlugin
2020
//Mod Details
2121
private const string modGUID = "Distance.DistanceModConfigurationManager";
2222
private const string modName = "Distance Mod Configuration Manager";
23-
public const string modVersion = "1.1.0";
23+
public const string modVersion = "1.1.1";
2424

2525
//Config Entry Settings
2626
public static string ShowVersionKey = "Show Version Info";
@@ -175,17 +175,17 @@ private MenuItemBase CreateUIForSetting(SettingEntryBase setting)
175175
if (setting.AcceptableValueRange.Key == null)
176176
{
177177
return new FloatSlider(MenuDisplayMode.Both, $"settings:{Regex.Replace(setting.DispName, @"\s+", "_").ToLower()}", setting.DispName.ToUpper())
178-
.WithDefaultValue((float)setting.DefaultValue)
179178
.LimitedByRange((float)setting.DefaultValue - 180, (float)setting.DefaultValue + 180)
179+
.WithDefaultValue((float)setting.DefaultValue)
180180
.WithGetter(() => (float)setting.Get())
181181
.WithSetter((x) => setting.Set(x))
182182
.WithDescription($"{setting.Description}");
183183
}
184184
else
185185
{
186186
return new FloatSlider(MenuDisplayMode.Both, $"settings:{Regex.Replace(setting.DispName, @"\s+", "_").ToLower()}", setting.DispName.ToUpper())
187-
.WithDefaultValue((float)setting.DefaultValue)
188187
.LimitedByRange((float)setting.AcceptableValueRange.Key, (float)setting.AcceptableValueRange.Value)
188+
.WithDefaultValue((float)setting.DefaultValue)
189189
.WithGetter(() => (float)setting.Get())
190190
.WithSetter((x) => setting.Set(x))
191191
.WithDescription($"{setting.Description}");
@@ -197,17 +197,17 @@ private MenuItemBase CreateUIForSetting(SettingEntryBase setting)
197197
if (setting.AcceptableValueRange.Key == null)
198198
{
199199
return new IntegerSlider(MenuDisplayMode.Both, $"settings:{Regex.Replace(setting.DispName, @"\s+", "_").ToLower()}", setting.DispName.ToUpper())
200-
.WithDefaultValue((int)setting.DefaultValue)
201200
.LimitedByRange((int)setting.DefaultValue, (int)setting.DefaultValue + 60)
201+
.WithDefaultValue((int)setting.DefaultValue)
202202
.WithGetter(() => (int)setting.Get())
203203
.WithSetter((x) => setting.Set(x))
204204
.WithDescription($"{setting.Description}");
205205
}
206206
else
207207
{
208208
return new IntegerSlider(MenuDisplayMode.Both, $"settings:{Regex.Replace(setting.DispName, @"\s+", "_").ToLower()}", setting.DispName.ToUpper())
209-
.WithDefaultValue((int)setting.DefaultValue)
210209
.LimitedByRange((int)setting.AcceptableValueRange.Key, (int)setting.AcceptableValueRange.Value)
210+
.WithDefaultValue((int)setting.DefaultValue)
211211
.WithGetter(() => (int)setting.Get())
212212
.WithSetter((x) => setting.Set(x))
213213
.WithDescription($"{setting.Description}");

0 commit comments

Comments
 (0)