Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a genuine calamity #100

Open
castdrian opened this issue May 31, 2023 · 2 comments
Open

a genuine calamity #100

castdrian opened this issue May 31, 2023 · 2 comments

Comments

@castdrian
Copy link

  • doesn't work on windows at all (codespaces, yay)
  • drops commands if they have options (omegalul)
  • deploys global commands in dev mode (why?)
  • none of the guide actually provides proper explanations or examples, whilst I can just read the source, it still is a pretty shit guide
@tristancamejo
Copy link
Member

Hey 👋,

Thanks for your feedback and bringing these issues to our attention.

  1. Windows compatibility: Disploy is designed to be platform-agnostic and should work on any operating system that supports Node.js (that includes Windows 🙃). If you're encountering a specific issue, could you consider providing more details (preferably in a new issue) such as error messages or logs? This will help us identify and fix the problem.

  2. Dropping commands with options: I think I know the issue you're experiencing with commands dropping when options are applied. The logic for diffing what needs to be updated was written in the middle of one of my classes, and it seems it needs a complete rewrite.

  3. Deploying global commands in dev mode: When using disploy dev, the idea is that you'd be using a different Discord application, not your production application, which is why it deploys globally. That being said, we understand that this might not be ideal for all use cases, and we're considering implementing a flag to control this behavior.

  4. Guide and documentation: I appreciate your feedback on our documentation. I strived to make Disploy as user-friendly as possible, and spent days writing up disploy.dev, and personally I agree with you, the docs/guide are a massive mess and hard to understand without any background knowledge. If there are specific areas or topics that you think need more detailed explanations or examples, your contributions would be greatly appreciated. Disploy is an open-source project, and we welcome all community contributions to help make it better.

@castdrian
Copy link
Author

  1. was a little exaggerated but mostly what's fucked is the create app cli since it looks for a path that doesn't exist on windows, very evident typo in the path to the executable

  2. took quite a while to figure out that that was the issue but good that at least it's on the radar

  3. that doesn't make much sense as a response overall. while developing you need to use guild commands as they populate changes instantly. using a different application does not resolve the fact that pushing global commands while developing is dumb, as you can't rely on any changes to the command structure actually being processed

  4. it's less that they're hard to understand it's just mostly that they're jumbled across with different code examples that apply to different releases which is a little yikes, but overall I'm more concerned with all the functional issues rather than the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants