Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not possible to turn off devtools #3428

Open
brianmay opened this issue Dec 22, 2024 · 0 comments
Open

not possible to turn off devtools #3428

brianmay opened this issue Dec 22, 2024 · 0 comments

Comments

@brianmay
Copy link

Problem

In my config.toml I specifically turned of default-features to turn of devtools:

dioxus = { version = "0.6.1", features = ["router", "fullstack", "asset", "document", "file_engine", "hooks", "html", "launch", "logger", "macro", "mounted", "signals"], default-features = false }

But I still get it - as proven by deliberately putting an error in the crate that would trigger if devtools enabled.

I think I worked it out.

In https://github.com/DioxusLabs/dioxus/blob/main/Cargo.toml

We do an import of dioxus-full-stack:

dioxus-fullstack = { path = "packages/fullstack", version = "0.6.1" }

But we haven't turned off default-features.

Then in fullstack we process the the default features:

https://github.com/DioxusLabs/dioxus/blob/main/packages/fullstack/Cargo.toml

default = ["devtools", "document", "file_engine", "mounted"]
devtools = ["dioxus-web?/devtools", "dep:dioxus-devtools"]

I believe that this in turn enabled devtools on dioxus-web because the crate rules say that the feature set for a package is all the features merged.

Code is here: https://github.com/brianmay/dioxus-fs-demo

Questionnaire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant