Return command returns all books borrowed by patron and do not give an option to select which book to return.

[Dineshraj555]

Description:
Program only allows patron all books together. This is defeats the purpose of the program as in reality this seems unreal.

Step to reproduce:
borrow 1 2 20-May-2022
borrow 1 1 20-May-2022
return p/1

Expected:
Able to select which book to return.

Actual:
Compulsory to return all books together.

[soc-pe-bot]

Team's Response

We think that this feature suggestion is not in scope of our app. (Note that bugs not in scope will have credit awarded to the tester based on the module website). Our explanation is as follows.

First of all you only mentioned about the “return p/” command, but did not mention about the “return b/….” command that allows librarians to return books one by one. The combination of these 2 return commands form 1 return feature, therefore should not be considered separately when considering for feature fit. Based on your description, if a librarian intends to, for example, return 2 out of the 3 borrowed books of a patron,then the librarian can just use the “return b/…” command two times.

You claimed that the “return p/” command is unrealistic, as no one would return all books together. When implementing this, we were thinking of a scenario where student A goes to librarian A at a counter with 5 books, the librarian searches for his name and books borrowed, then realizes he only has 5 books borrowed. Since he borrowed all 5 books, this saves work for the librarian for not 5 return commands. Therefore we argue that return p/ is not useless, it actually helps save time.

The suggested feature of returning certain selected books is not that useful because you are expecting something like return b/1 100 101 to return books are index 1, 100, 101. The index can be large since library has many books. The time to scroll through the list to identify the index, and then typing return b/1 100 101 may be slower then finding the individual books by name, then use “return b/1” to return the single book, and then the second and third book.

We do acknowledge that under rare cases, having a command such as “return b/1 100 101” to return books at multiple indexes is useful, but most of the time the same functionality can be achieved with the package of commands offered by LibTask. Furthermore, this behavior is also not advertised in UG and the user cannot attempt to use it and result in the app crashing. We also warned the user of invalid input format with an error message if he attempts to do something like "return b/1 2 3" to return multiple specific books (i.e. fails gracefully). Hence, we think that this feature suggestion is out of scope of our app.

Downgraded to low because as justified above, this feature is not essential.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

• I disagree

Reason for disagreement: I think the return b/- should have the option of returning multiple books as these program is designed to help librarian complete their daily task quickly (as suggested in the UG) but it is not efficient to repeat the same command multiple times. I strongly feel this is a medium severity issue as the above problem will cause occasional inconvenience to most users.

---

❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

• I disagree

Reason for disagreement: [replace this with your reason]

---