Program accepts invalid phone numbers to be stored.

[Dineshraj555]

Description:
Attempted to edit phone numbers to invalid phones number and turned out to be successful.

Step to reproduce:
patron edit 1 p/39393944445555666666

Expected:
Error message stating Invalid phone number.

Actual:
No error message and phone number entered was accepted and stored.

[nus-se-bot]

Team's Response

This is a duplicate of issue #2906 because both issues are reporting the exact same issue. They are both trying inputs with long phone numbers and expecting our app to show error message saying invalid phone number.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Accepting invalid phone numbers

Add patron accepting invalid phone numbers

---

_{[original: nus-cs2103-AY2122S2/pe-interim#2872] [original labels: severity.Low type.FeatureFlaw]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

In your case, you are trying a long input and expecting the system to identify the phone number as invalid. We deliberately chose not to validate the length of the input because we expect some phone numbers to be international phone numbers of international students. Some of them, especially freshmen, may not have updated their Singapore phone numbers. If we restrict the length of the phone number to 8 digits to suit Singapore phone number’s format, some other testers will also report it as an overzealous input validation bug. We chose to not restrict input size to not restrict the user for inputting certain non-Singapore numbers, and this benefit outweighs the benefit of restricting input, because if the user makes a typo in command, he/she can always use edit command to reverse the mistake. If we restrict the input, there is no way the user can input some valid phone numbers that do not fit our format.

The recommendation for not having unreasonable limits on phone numbers is also mentioned in the module website:

Also, it is not reasonable to expect us to know every valid phone number input format, because every country and region has their own phone format.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• I disagree

Reason for disagreement: [replace this with your explanation]

---

❓ Issue response

Team chose [response.Rejected]

• I disagree

Reason for disagreement: Yes my input is long but it is not invalid. Other countries permit such as length numbers but the validation regex on the phone is too loose such as permitting any numbers more than 3 digits which is same as the original AB3. Moreover the UG did not specify any instruction on the phone number field. Being a mandatory field to add patrons, I strongly feel a stronger validation regex is required.

---

❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

• I disagree

Reason for disagreement: [replace this with your explanation]

---