Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scan calculations out of nexgen #99

Open
DominicOram opened this issue Jan 20, 2023 · 1 comment
Open

Move scan calculations out of nexgen #99

DominicOram opened this issue Jan 20, 2023 · 1 comment

Comments

@DominicOram
Copy link
Collaborator

As a user of nexgen I would like to provide the scan details myself rather than the current system of the scan being assumed as part of the goniometer structure. I propose that we provide this using scanspec as it's an existing library which makes it easy to construct scans.

Nexgen should probably still be responsible for creating the additional omega scan values (when none are provided) as this is a quirk of the nexus structure that omega values are always required so shouldn't be exposed to the user.

Acceptance Criteria

  • nexgen can be called with a full scan specification and will write this
  • The detail around the scan in the gonio structure (e.g. increment, start and end) becomes optional
  • nexgen will create the omega scan part if this hasn't already been provided
  • There are unit tests covering all the above

Note

  • Currently i24 still relies on nexgen to build the scan, if this is still the case when this ticket is done then create a new one for removing the scan generation code once no longer required by i24
@noemifrisina
Copy link
Collaborator

First part of the work done in #110 and Artemis#599. Scans are calculated and passed directly from artemis. End and increment positions are now optional, but for the moment the start position is not.
Merging #110 to get this first change working. There's still some work to be done on creating omega if not passed (and some tests to be added) but that will go in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants