-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not write unused VDS files in the first place #87
Comments
Turns out the issue is not just that it is linked but that it is actually used as a source for the VDS as well |
d-perl
added a commit
to d-perl/nexgen
that referenced
this issue
Dec 7, 2022
and function to clean unused links
d-perl
added a commit
to d-perl/nexgen
that referenced
this issue
Dec 7, 2022
noemifrisina
pushed a commit
that referenced
this issue
Dec 7, 2022
#92 fixes this issue and is good as an urgent fix required for the beamline but I think we could do more:
|
This is still not fixed properly, and should be looked into |
DominicOram
changed the title
Unused linked dataset causes issues with dlstbx
Do not write unused VDS files in the first place
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When, in artemis, we have a large grid, there are more than two datasets linked in the nexus files, and for the second nexus file, the first dataset may not be used. In that case,
https://github.com/DiamondLightSource/python-dlstbx/blob/main/src/dlstbx/swmr/h5check.py
fails when running
because that dataset has no corresponding slab of the vds.
I would like it if completely unused datasets are not linked in the nexus file.
The text was updated successfully, but these errors were encountered: