Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename kwargs #8

Open
DhairyaLGandhi opened this issue Jan 17, 2022 · 1 comment
Open

Rename kwargs #8

DhairyaLGandhi opened this issue Jan 17, 2022 · 1 comment

Comments

@DhairyaLGandhi
Copy link
Owner

A lot of the kwargs are currently named confusingly. For example cycle refers to the number of times we sample the imagnet dataset to produce a fresh batch of images, for which nsamples sounds ideal. However, nsamples is used to denote the number of samples that are pulled out at every sampling.

We also need to use a path instead of a boolean for saveweights. Currently it saves these weights in a very blackbox manner, and indeed as a package it would fail to operate within the package directory. It needs to operate on a user defined path (which has write permissions).
@DhairyaLGandhi
Copy link
Owner Author

We should also rename HOST since it has an existing meaning in GPU land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DhairyaLGandhi