Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor prepare_training #41

Open
DhairyaLGandhi opened this issue Mar 18, 2022 · 1 comment
Open

Refactor prepare_training #41

DhairyaLGandhi opened this issue Mar 18, 2022 · 1 comment

Comments

@DhairyaLGandhi
Copy link
Owner

prepare_training currently has a few complexities. Specifically, it does a lot. From setting up buffers, to initialising states of optimisers and instantiating the dataloaders. Some parts of this exercise can definitely be held generically, but as we move towards different datasets (#33 ) it might be the right time to refactor this function and define an API for hooking in additional datasets.
@DhairyaLGandhi
Copy link
Owner Author

ref #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DhairyaLGandhi