Align pin parity with packaged winget

Author: mamoreau-devolutions

dotnet/src/Devolutions.Pinget.Core.Tests/CoreTests.cs

@@ -688,7 +688,7 @@ PRIMARY KEY (package_id, source_id)
 
             using var reader = verifyCmd.ExecuteReader();
             Assert.True(reader.Read());
-            Assert.Equal(2L, reader.GetInt64(0));
+            Assert.Equal(3L, reader.GetInt64(0));
             Assert.Equal("1.2.*", reader.GetString(1));
         }
         finally

dotnet/src/Devolutions.Pinget.Core/PinStore.cs

@@ -66,9 +66,9 @@ PRIMARY KEY (package_id, source_id)
 
         int typeInt = pinType switch
         {
-            PinType.Blocking => 1,
-            PinType.Gating => 2,
-            _ => 0
+            PinType.Blocking => 4,
+            PinType.Gating => 3,
+            _ => 2
         };
 
         using var cmd = conn.CreateCommand();
@@ -157,8 +157,8 @@ private static PinType ToPinType(long pinTypeValue)
     {
         return pinTypeValue switch
         {
-            1 => PinType.Blocking,
-            2 => PinType.Gating,
+            4 => PinType.Blocking,
+            3 => PinType.Gating,
             _ => PinType.Pinning
         };
     }

rust/crates/pinget-core/src/lib.rs

@@ -1130,9 +1130,9 @@ impl Repository {
         )?;
         let pin_type_column = resolve_pin_type_column(&conn)?.unwrap_or("type");
         let type_int: i64 = match pin_type {
-            PinType::Pinning => 0,
-            PinType::Blocking => 1,
-            PinType::Gating => 2,
+            PinType::Pinning => 2,
+            PinType::Blocking => 4,
+            PinType::Gating => 3,
         };
         conn.execute(
             &format!(
@@ -5563,8 +5563,8 @@ fn resolve_pin_type_column(conn: &Connection) -> Result<Option<&'static str>> {
 
 fn decode_pin_type(pin_type_int: i64) -> PinType {
     match pin_type_int {
-        1 => PinType::Blocking,
-        2 => PinType::Gating,
+        4 => PinType::Blocking,
+        3 => PinType::Gating,
         _ => PinType::Pinning,
     }
 }
@@ -7749,7 +7749,7 @@ Installers:
                 rusqlite::params!["Contoso.Tool", "winget"],
                 |row| Ok((row.get::<_, i64>(0)?, row.get::<_, String>(1)?)),
             )?;
-            assert_eq!(stored_pin.0, 2);
+            assert_eq!(stored_pin.0, 3);
             assert_eq!(stored_pin.1, "1.2.*");
 
             Ok(())

rust/tools/Smoke-Compare-WingetParity.ps1

@@ -571,11 +571,9 @@ function Test-PinVisible {
         [switch]$SystemCli
     )
 
-    $commandArgs = if ($SystemCli) {
-        @("pin", "list", "--accept-source-agreements", "--disable-interactivity")
-    }
-    else {
-        @("pin", "list", $PackageId)
+    $commandArgs = @("pin", "list", "--id", $PackageId, "--exact")
+    if ($SystemCli) {
+        $commandArgs += @("--accept-source-agreements", "--disable-interactivity")
     }
 
     $result = Invoke-Capture -Executable $Executable -Arguments $commandArgs
@@ -590,7 +588,7 @@ function Remove-PinIfPresent {
     )
 
     if (Test-PinVisible -Executable $Executable -PackageId $PackageId -SystemCli:$SystemCli) {
-        $removeArgs = @("pin", "remove", $PackageId)
+        $removeArgs = @("pin", "remove", "--id", $PackageId, "--exact")
         if ($SystemCli) {
             $removeArgs += @("--accept-source-agreements", "--disable-interactivity")
         }