Add VS2022 build instructions and update CLion and MSVC guide, and minor fixes

Author: DevGeniusCode

Asset/Localization/localization_contribution.md

@@ -21,17 +21,14 @@ Sections Included:
 - **FR**: [French](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2639)
 - **ES**: [Spanish](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2538)
 - **IT**: [Italian](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2539)
-- **KO**: [Korean](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2540)
-- **ZH**: [Chinese Traditional](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2541)
 - **BP**: [Brazilian Portuguese](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2542)
 - **PL**: [Polish](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2543)
-- **RU**: [Russian](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2544)
-- **UK**: [Ukrainian](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2628)
 
 1.2.1 **Arabic & RTL Languages**: Arabic and other Right-to-Left (RTL) languages are currently compiled with an error
 when used in the game. This issue will be fixed soon. If you would like to help resolve this issue or test the upcoming
 fix, please let us know in the comment section of the
 *AR: [Arabic](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2546) localization edit*.
+More info in [Adding RTL markers in RTL localization for GameTextCompiler](https://github.com/TheSuperHackers/GeneralsGamePatch/discussions/2659).
 
 1.3 **Leave Comments on Edits**: You can reply to existing comments or review the changes yourself. To do so, click on
 the **Files changed** tab under the pull request title. If prompted, press **Load diff** to view the changes (if an
@@ -43,7 +40,7 @@ implement. This helps us process the change faster.
 
 1.5 **Non-English Localization**: If you contributed to non-English localization (e.g., Polish), please also check these
 two branches for text changes in all languages:
- **[United States English](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2535)** and **[Missing text lines](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2571)**.
+**[United States English](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2535)** and **[Missing text lines](https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2571)**.
 
 ## 2. Working on Existing Languages
 
@@ -55,10 +52,13 @@ changes already commented on in the file:
 
 2.2 **Editing Tools**: I use **[Notepad++](https://notepad-plus-plus.org/downloads/)** for editing files. If you're
 using Linux or macOS, you can use similar programs that offer the same features as Notepad++.
+It is **required** to use **UTF-8** text format to avoid compatibility issues across different platforms and text
+editors. Ensure that your editor is set to save files in UTF-8 encoding to maintain proper character representation
+and prevent any potential issues with special characters.
 
 2.3 **Translation Tools**: I use
- **[Google Translate](https://translate.google.ca/?hl=en&tab=TT&sl=auto&tl=en&op=translate)** for quick translations,
-  but I recommend using your language dictionary in some cases. I personally use **[Multitran](https://www.multitran.com/)**
+**[Google Translate](https://translate.google.ca/?hl=en&tab=TT&sl=auto&tl=en&op=translate)** for quick translations,
+but I recommend using your language dictionary in some cases. I personally use **[Multitran](https://www.multitran.com/)**
 for this.
 
 2.4 **Grammar Checking**: For additional grammar checks, I use **[Free Grammar Checker](https://languagetool.org/)**.

SourceCode/Builds/build_with_clion_vc6_toolchain.md

@@ -5,23 +5,23 @@
 1. **CLion** installed and configured.
 2. **Microsoft Visual C++ 6.0 (VC6)** installed (assuming it’s installed in the
    default directory).
-3. **CMake** installed and configured.
-4. **Source code** of the project cloned from the TheSuperHackers repository.
+3. **Source code** of the project cloned from the TheSuperHackers repository.
 
 ## Step 1: Setting Up the Toolchain in CLion
 
-1. Open **CLion** and go to **File** -> **Settings** -> **Build, Execution,
+1. Open the cloned folder in **CLion** and go to **File** -> **Settings** -> **Build, Execution,
    Deployment** -> **Toolchains**.
 2. Add a new **Toolchain** by clicking the **+** button.
 3. Select **System** as the Type (not Visual Studio).
-4. Next to the toolchain name, add the **environment** file by clicking the
+4. Rename the toolchain to **Visual Studio 6**
+5. Next to the toolchain name, add the **environment** file by clicking the
    **+** button and pointing to the following file:
 
    ```text
    C:\Program Files (x86)\Microsoft Visual Studio\VC98\Bin\VCVARS32.BAT
    ```
 
-5. Set the paths for the tools:
+6. Set the paths for the tools:
     - **Build Tool**: Choose the `NMAKE.EXE` file from VC6. For example:
 
       ```text
@@ -39,39 +39,31 @@
 
 ## Step 2: Configuring the CMake Profile
 
-1. Go to **File** -> **Settings** -> **Build, Execution, Deployment** -> **CMake**.
-2. In this window, select the CMake profile you want to configure (if there
-   isn’t one, create a new one).
-3. Choose the **Toolchain** you created in the previous step (VC6 Toolchain).
-4. Choose the **Generator** as `NMake Makefiles`.
-5. Under **CMake options**, add the following generate settings:
+1. In Cmake profiles, enable the profiles you want to use, like vc6, vc6dgb, vc6int, vc6prof.
 
-   ```text
-      -G "NMake Makefiles"
-   ```
+## step 3: Configuring the installation path
 
-   Be careful not to set `Preset`, as it will override the generator settings.
-6. Add the build directory path under **CMake Build Directory**:
+1. In the target application options, do the following:
 
-   ```text
-   C:\Users\User\Documents\CLion\CnC_Generals_Zero_Hour\build\vc6
-   ```
+- Set Program arguments with your favorite arguments,like `-win, -quickstart, -nologo`.
+- Set Working directory to the game directory.
+- Check the run as administrator option.
+- In 'Before launch' section, add a new 'install' step.
+- To avoid duplication build, remove the 'Build' step.
+- Save the configuration, and you are ready to build and run the project.
 
-## Step 3: Compiling and Running the Project
+## Step 4: Compiling and Running the Project
 
-1. Now, click the **Build** button in CLion.
-2. CLion will start the build process using the VC6 (x86) toolchain.
-3. Once the build is successfully completed, a **zerohour.exe** file will be generated.
-4. You need to copy the **zerohour.exe** file to the appropriate game directory in order to run the game.
+1. Now, click the **Build** button in CLion, or click **Install** in build menu.
+2. CLion will start the build/install process using the VC6 (x86) toolchain.
+3. Once the build is successfully completed, a executable file will be generated (and installed in the game directory).
 
 ---
 
 ## Notes
 
-- **Visual C++ 6.0 (VC6)** only supports C++98, so avoid using modern C++ features.
 - Working with VC6 requires some adjustments, so it’s always a good idea to check
-  that the toolchain is working
-  properly.
+  that the toolchain is working properly.
 - You can add Release and Debug profiles in CLion to build the project in
   different configurations.
-- Admin rights might be required to run VC6 tools, so make sure to run CLion as an administrator.
+- Admin rights might be required to run VC6 tools, so make sure to run CLion as an administrator if needed.

SourceCode/Builds/build_with_msvc22.md

@@ -1,62 +1,87 @@
-# Building and Compiling C&C Generals on Visual Studio 2022
+# Building and Compiling C&C Generals & Zero Hour on Visual Studio 2022
 
-## Prerequisites
-
-1. **Install Visual Studio 2022**
-    - Ensure that the necessary C++ development components, including MFC, are installed.
-
-2. **Obtain the C&C Generals Source Code**
-    - Clone or download the source code repository: [TheSuperHackers - GeneralsGameCode](https://github.com/TheSuperHackers/GeneralsGameCode.git).
-
-3. **Install C&C Generals (Steam Version)**
-    - The game installation is required to access the necessary asset files.
-
-## Build Steps
-
-### 1. Open the Project in Visual Studio 2022
-
-- Launch Visual Studio 2022 and open the solution file `Code/RTS.sln`.
-
-### 2. Select and Compile the Required Projects
-
-- In the **Solution Explorer**, locate the following projects:
-  - `RTS`
-  - `WorldBuilder`
-- Right-click each project and select **Build**.
-- Ensure the build process completes without errors.
+This guide will walk you through the process of basic setup and compilation of the C&C Generals and Zero Hour source
+code using Visual Studio 2022.
+For build using solutions and more advanced build configurations, see below.
 
-### 3. Copy Required Game Files from Steam
-
-- Navigate to your C&C Generals Steam installation directory, typically:
-
-  ``` text
-  C:\Program Files (x86)\Steam\steamapps\common\Command and Conquer Generals Zero Hour\
-  ```
-
-- Copy all necessary `.BIG` files into the `Run` folder of your compiled project:
-
-  ``` text
-  EnglishZH.big
-  INIZH.big
-  SpeechZH.big
-  W3DZH.big
-  (Other required files)
-  ```
-
-- Copy the entire `Data` folder to the `Run` folder as well.
-
-### 4. Configure Paths Correctly
-
-- Ensure that the `Run` folder within your build directory contains all required game assets.
-- If necessary, configure the **working directory** in Visual Studio:
-    1. Right-click on the `RTS` project.
-    2. Navigate to **Properties** → **Debugging**.
-    3. Set `Working Directory` to your `Run` folder.
-
-### 5. Run the Game or World Builder
+## Prerequisites
 
-- After compiling, navigate to the `Run` folder.
-- Launch `RTSD.exe` or `worldbuilder.exe`.
+1. **Visual Studio 2022**
+
+- Ensure that the necessary C++ development components, **including MFC**, are installed.
+
+>[!WARNING]
+> You must have the MFC components installed to compile the source code.
+<!-- markdownlint-disable-next-line -->
+2. **Obtain the Source Code (Step 1)**
+    - Clone or download the source code
+      repository: [TheSuperHackers - GeneralsGameCode](https://github.com/TheSuperHackers/GeneralsGameCode.git).
+
+## Steps
+
+### 1. Clone and prepare the project
+
+- Clone the repository to your local machine.
+- Open the folder in Visual Studio 2022.
+- Wait for Visual Studio to generate the necessary cmake files.
+
+### 2. Build the Project
+
+- Select you favorite build configuration:
+- `Build Windows build` for a release build.
+- `Build Windows Debug build` for a debug build.
+- `Build Windows Internal build` for an internal build.
+- `Build Windows Profile build` for a profile build.
+
+>[!TIP]
+> For more information on the different build configurations, see the [Build Configurations](build_configurations.md)
+page.
+
+- Select the target you want to build:
+- `generalsv.exe` to build the base Generals.
+- `generalszh.exe` to build Zero Hour.
+
+- Build the project by clicking on the `Build` menu and selecting `Build`.
+- The compiled executable will be placed in the `build/<win32 build type>/<game name (Generals/GeneralsMD)>/<build configuration>`
+  folder. Example: `build/win32dgb/GeneralsMD/Debug`
+- Install the game executable in the game directory by clicking on the `Install` in `Build` menu. This will copy the
+  executable to the retail game directory.
+
+## Additional Steps
+
+### Build through Cmake target view
+
+- In the Solution Explorer, click on 'switch view' and select 'CMake Targets View'.
+- Expand the 'Genzh' project and right-click on the target you want to build.
+- Select 'Build' to compile the target.
+
+### Build using command line
+
+You need to install cmake and ninja to build the project from the command line.
+
+- In the developer command prompt, open the settings to add the x86 environment terminal.
+
+>[!Tip]
+> Alternatively, you can open the x86 Native Tools Command Prompt from the start menu, and navigate to the project
+   directory in the terminal then run the commands below.
+  
+- In the pop-up window, click on the 'Add' and set the following: (assuming default installation path)
+  - Name: `x86 Native Tools Command Prompt`
+  - Shell Location: `C:\Windows\System32\cmd.exe`
+  - Arguments: `/k "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars32.bat"`
+- Now you can open the new terminal from the terminal dropdown list.
+- Run the following commands to build the project:
+- Choose the build configuration:
+  - `cmake --workflow --preset win32` for Release build.
+  - `cmake --workflow --preset win32dgb` for Debug build.
+  - `cmake --workflow --preset win32int` for Internal build.
+  - `cmake --workflow --preset win32prof` for Profile build.
+- Install the game executable in the game directory (assuming that the build was successful):
+  - `cmake --install build/<preset name>`
+- To build a specific target:
+  - Run `cmake --build build/<preset name> --target <target name>`
+  - Example: `cmake --build build/win32 --target z_generals`
+  - Or: `cmake --build build/win32 --target g_generals`
 
 ## Troubleshooting
 

SourceCode/Builds/build_with_msvc6.md

@@ -52,23 +52,19 @@ Installation of tools and software that are needed for compilation.
 
 ## Clone
 
-> **_NOTE:_**  The source code you clone is from the WIP from OmniBlade.
+Clone the code from TheSuperHackers
 
-Clone the code from WIP OmniBlade -> TheSuperHackers
+`git clone https://github.com/TheSuperHackers/GeneralsGameCode.git`
 
-`git clone https://github.com/OmniBlade/CnC_Generals_Zero_Hour.git`
-
-`cd CnC_Generals_Zero_Hour`
-
-`git switch blade/cmake-build`
+`cd GeneralsGameCode`
 
 ## Compilation
 
 This steps you need to repeat every time after a reboot of your computer.
 
 ### Option 1: Activate your VS6 Compiler Environment
 
-Execute the setup build environment script. In your cmd type this.
+Execute the setup build environment script. In your cmd type this. (assuming default installation path)
 
 `"C:\Program Files (x86)\Microsoft Visual Studio\VC98\Bin\VCVARS32.bat"`
 
@@ -106,21 +102,21 @@ set CXX=C:\<VS6_INSTALL_PATH>\VC98\Bin\CL.exe
 set MSVCDir=C:\<VS6_INSTALL_PATH>\VC98
 ```
 
-### Compiling
-
-`cmake --preset vc6`
-
-`cd build\vc6`
+### Build the project
 
-`nmake`
+Run the following command by the type of build you want to create.
 
-You will find a bunch of files in `build\vc6` and a file called `zerohour.exe`
+- `cmake --workflow --preset vc6` for a release build.
+- `cmake --workflow --preset vc6dgb` for a debug build.
+- `cmake --workflow --preset vc6int` for an internal build.
+- `cmake --workflow --preset vc6prof` for a profile build.
 
-Copy `zerohour.exe` of the build folder to your game path.
+You will find a bunch of files in `build\vc6\<game name>` and a file called `generalszh.exe` or `generalsv.exe`.
 
-## Start the game
+### Install the game executable
 
-Double click `zerohour.exe` inside the Zero Hour path.
+Run `cmake --install build\<vc6 build type>`, this will copy the executable to the retail game directory, or you can
+copy it manually.
 
 ## Troubleshooting