Improve Swift type extraction coverage - #613
Conversation
|
Huge thanks for opening this PR and for the work you put into it. The maintainer shop is currently full, so this may sit for a bit before it gets a proper review. We will come back to this as soon as possible with real feedback; I wanted to make sure it did not sit unacknowledged in the meantime. |
|
Thanks for improving Swift extraction coverage. Before review can continue, please add a DCO |
Signed-off-by: xbsjason <xbsjason@gmail.com>
|
Thank you for the Swift extraction work, and apologies that this has been sitting. The CI failure here is a small one and it is genuinely in your diff — clang-format violations on your own lines in One thing that will save you a frustrating round trip: our CI lint uses the Homebrew LLVM clang-format specifically. A standalone The reliable local check is: which runs the same cppcheck + clang-format combination CI does, so a green result there means a green result on the runner. Once that is clean I will give the extraction change itself a proper review — Swift type coverage is squarely the kind of graph-quality improvement we want, so it is worth finishing. |
Summary
Related issue
Verification
swift_protocol,swift_struct,swift_enum, and Swift call extraction all pass.Caveat
make -f Makefile.cbm cbmcurrently fails on this machine in pre-existing production allocator code withunknown type name git_allocatorwhenCBM_BIND_TS_ALLOCATOR=1.