Ignore derived ::missed projects when resolving stores

Author: Bogyie

src/mcp/mcp.c

@@ -1565,10 +1565,27 @@ static bool db_internal_project_name(const char *full_path, char *name_out, size
     cbm_project_t *projs = NULL;
     int n = 0;
     bool ok = false;
-    if (cbm_store_list_projects(st, &projs, &n) == CBM_STORE_OK && n == 1 && projs[0].name &&
-        projs[0].name[0]) {
-        snprintf(name_out, name_sz, "%s", projs[0].name);
-        ok = true;
+    if (cbm_store_list_projects(st, &projs, &n) == CBM_STORE_OK) {
+        const char *base_project = NULL;
+        int base_count = 0;
+        static const char missed_suffix[] = "::missed";
+        for (int i = 0; i < n; i++) {
+            const char *candidate = projs[i].name;
+            if (!candidate || !candidate[0]) {
+                continue;
+            }
+            size_t len = strlen(candidate);
+            size_t suffix_len = sizeof(missed_suffix) - SKIP_ONE;
+            if (len >= suffix_len && strcmp(candidate + len - suffix_len, missed_suffix) == 0) {
+                continue; /* derived coverage graph, not a separately addressable project */
+            }
+            base_project = candidate;
+            base_count++;
+        }
+        if (base_count == 1 && strlen(base_project) < name_sz) {
+            snprintf(name_out, name_sz, "%s", base_project);
+            ok = true;
+        }
     }
     cbm_store_free_projects(projs, n);
     if (ok && out_store) {

src/store/store.c

@@ -2013,6 +2013,10 @@ static void cov_rebuild_shadow_graph(cbm_store_t *s, const char *project) {
             sqlite3_finalize(del);
         }
     }
+    /* The projects row is derived too. Remove it before rebuilding so a run
+     * whose current coverage has no failures does not leave a stale
+     * <project>::missed entry behind. It is re-created below when needed. */
+    (void)cbm_store_delete_project(s, covproj);
 
     cbm_coverage_row_t *rows = NULL;
     int count = 0;
@@ -2035,8 +2039,8 @@ static void cov_rebuild_shadow_graph(cbm_store_t *s, const char *project) {
     }
 
     /* nodes.project has an FK to projects(name) (enforced: foreign_keys=ON),
-     * so the shadow project needs its row. Invisible to list_projects, which
-     * scans the cache directory for .db files, not this table. */
+     * so the shadow project needs its row. list_projects scans DB files and
+     * explicitly ignores the ::missed internal row when resolving each file. */
     if (cbm_store_upsert_project(s, covproj, "") != CBM_STORE_OK) {
         cbm_store_free_coverage(rows, count);
         return;

tests/test_mcp.c

@@ -4449,6 +4449,14 @@ TEST(tool_resolve_store_by_internal_name_issue704) {
 
     /* (1) control: filename == internal name */
     ASSERT_TRUE(issue704_make_db(cache, "alpha704.db", "alpha704", "alphaFunc704"));
+    /* Coverage materializes a second internal projects row in the same DB.
+     * list_projects must ignore this derived graph and still advertise alpha. */
+    char alpha_path[700];
+    snprintf(alpha_path, sizeof(alpha_path), "%s/alpha704.db", cache);
+    cbm_store_t *alpha_store = cbm_store_open_path(alpha_path);
+    ASSERT_NOT_NULL(alpha_store);
+    ASSERT_EQ(cbm_store_upsert_project(alpha_store, "alpha704::missed", ""), CBM_STORE_OK);
+    cbm_store_close(alpha_store);
 
     /* (2) DRIFT: build beta704.db (internal "beta704") then rename the file to
      *     gamma704.db, so filename "gamma704" != internal "beta704". */
@@ -4526,18 +4534,16 @@ TEST(tool_resolve_store_by_internal_name_issue704) {
     } else {
         cbm_unsetenv("CBM_CACHE_DIR");
     }
-    char a_path[700];
-    snprintf(a_path, sizeof(a_path), "%s/alpha704.db", cache);
     char corrupt_path[720];
     snprintf(corrupt_path, sizeof(corrupt_path), "%s.corrupt", ghost_path);
-    cbm_unlink(a_path);
+    cbm_unlink(alpha_path);
     cbm_unlink(gamma_path);
     cbm_unlink(ghost_path);
     cbm_unlink(corrupt_path); /* ghost may be quarantined by resolve_store */
     char side[740];
-    snprintf(side, sizeof(side), "%s-wal", a_path);
+    snprintf(side, sizeof(side), "%s-wal", alpha_path);
     cbm_unlink(side);
-    snprintf(side, sizeof(side), "%s-shm", a_path);
+    snprintf(side, sizeof(side), "%s-shm", alpha_path);
     cbm_unlink(side);
     snprintf(side, sizeof(side), "%s-wal", gamma_path);
     cbm_unlink(side);

tests/test_store_nodes.c

@@ -1663,6 +1663,9 @@ TEST(store_coverage_roundtrip_prune_shadow) {
     ASSERT_EQ(cbm_store_find_nodes_by_label(s, "test::missed", "File", &nodes, &nc), CBM_STORE_OK);
     ASSERT_EQ(nc, 0);
     cbm_store_free_nodes(nodes, nc);
+    cbm_project_t shadow = {0};
+    ASSERT(cbm_store_get_project(s, "test::missed", &shadow) != CBM_STORE_OK);
+    cbm_project_free_fields(&shadow);
 
     cbm_store_close(s);
     PASS();