Skip to content

Commit 587d271

Browse files
Venugopal NadipalliNurKeinNeid
authored andcommitted
Camera: Removing cachedump call to miminimize delay during close.
- The cacheDump() call was added for better debugging by always dumping the state of the last camera session. Since LT/VT chipsets it is adding significant delay during camera close. Hence we are removing cachedump call during disconnect. https://partnerissuetracker.corp.google.com/issues/237992867 CRs-Fixed: 3228616 Change-Id: Ibba2a51f08c592bf15b046642101e11d890ed248 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
1 parent b836b7f commit 587d271

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

services/camera/libcameraservice/common/Camera2ClientBase.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -272,14 +272,6 @@ binder::Status Camera2ClientBase<TClientBase>::disconnectImpl() {
272272

273273
ALOGD("Camera %s: Shutting down", TClientBase::mCameraIdStr.c_str());
274274

275-
// Before detaching the device, cache the info from current open session.
276-
// The disconnected check avoids duplication of info and also prevents
277-
// deadlock while acquiring service lock in cacheDump.
278-
if (!TClientBase::mDisconnected) {
279-
ALOGD("Camera %s: start to cacheDump", TClientBase::mCameraIdStr.c_str());
280-
Camera2ClientBase::getCameraService()->cacheDump();
281-
}
282-
283275
detachDevice();
284276

285277
CameraService::BasicClient::disconnect();

0 commit comments

Comments
 (0)