perf: deduplicate concurrent model catalog fetches#75
Open
kumarabhirup wants to merge 2 commits into
Open
Conversation
Replace cryptic 'Unauthorized' responses with descriptive messages that tell the user what went wrong and how to fix it: - HTTP auth failures now include specific reasons (token_mismatch, password_missing, trusted_proxy_untrusted_source, etc.) with actionable hints (which env var or config key to check) - WebSocket upgrade 401s now return JSON with the failure reason instead of a bare 'HTTP/1.1 401 Unauthorized' - Webhook auth failures explain secret mismatch - assertGatewayAuthConfigured password error now suggests the env var - gateway URL override error explains what credentials are needed Closes #33
ensureOpenClawModelsJson is called from many concurrent code paths (model catalog loader, agent context, image tools, embedded runner) and performs filesystem I/O (resolve providers → read/write models.json) on every call. Store the in-flight promise and return it to subsequent callers so only the first concurrent request does the actual work. The promise is cleared once settled so future calls pick up config changes. Callers that pass explicit config/agentDir overrides bypass the cache to preserve their custom semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25
Adds promise deduplication to
ensureOpenClawModelsJsonso concurrent callers share the same in-flight promise instead of triggering redundant filesystem I/O.