Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Five test cases failed in python unit tests #1078

Open
hyihua opened this issue Dec 10, 2023 · 3 comments
Open

Five test cases failed in python unit tests #1078

hyihua opened this issue Dec 10, 2023 · 3 comments
Assignees
Labels
Back End Primarily back-end (python/django) code for this task python Pull requests that update Python code

Comments

@hyihua
Copy link
Collaborator

hyihua commented Dec 10, 2023

Situation: When @qchiujunhao and I are working on #1055 , one runner log shows that there exists errors in 5 test cases which leaded to the failure of the job.

Target: Correct the test cases to pass the tests.

@hyihua hyihua self-assigned this Dec 15, 2023
@qchiujunhao qchiujunhao added python Pull requests that update Python code Back End Primarily back-end (python/django) code for this task labels Dec 18, 2023
@hyihua
Copy link
Collaborator Author

hyihua commented Dec 31, 2023

After reviewing the codebase and the runner log, the issue should be related to the following code line.

8df3bd194ba2117e99d6c57fe951199

I think the question now is to figure out the initial value set for expect_succeeded (10 or 5).

@qchiujunhao qchiujunhao self-assigned this Jan 11, 2024
@qchiujunhao
Copy link
Collaborator

qchiujunhao commented Feb 8, 2024

The likely cause of the error can be narrowed down to the function make_many_requests in the file civictechprojects/tests/test_view.py, possibly in relation to the throttling mechanism.

@ddfridley
Copy link
Collaborator

@hyihua Hi, I'm helping with development focus for DemocarcyLab. We've created a DemocracyLab Dashboard and would like to update the status of this issue.

  • Are you still working on it? If so, what are the next steps, or what challenges are there to moving forward?
  • Or is this still an issue/should we close it?
  • Or, if you just aren't available to work on it anymore, please let me know, and/or unassign yourself
  • Or something else?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back End Primarily back-end (python/django) code for this task python Pull requests that update Python code
Projects
Status: In progress
Development

No branches or pull requests

3 participants