fix: report retryable storage URL errors with their response body

Errors from the pre-signed translation memory upload and download URLs
now set should_retry for HTTP 429 and 5xx, and a failed streamed
download includes its response body in the message. They stay a plain
DeepLException with http_status_code, as these URLs are not DeepL API
endpoints.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: hive-bot

CHANGELOG.md

@@ -242,6 +242,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   connect to the proxy), are no longer retried and raise `ConnectionException`
   with `should_retry` `False`.
 - Query string values encode a space as `%20` instead of `+`.
+- Fixed errors from the pre-signed translation memory upload and download URLs
+  reporting `should_retry` as false for HTTP 429 and 5xx, and dropping the
+  response body of a failed download from the message.
 - HTTP 401 responses now raise `AuthorizationException`, like 403. Before they
   raised `DeepLException` with "Unexpected status code: 401".
 - `DeepLException.should_retry` is now `True` for every HTTP 5xx error. It was

README.md

@@ -1268,6 +1268,13 @@ job = deepl_client.wait_until_translation_memory_job_done(
 )
 ```
 
+Errors from the pre-signed upload and download URLs are not DeepL API errors:
+`upload_translation_memory_file()` and `download_translation_memory_export()`
+raise a plain `DeepLException` with the response body in the message,
+`http_status_code` set, and `should_retry` true for HTTP 429 and 5xx. An
+expired URL (for example HTTP 403) therefore does not raise
+`AuthorizationException`.
+
 `TranslationMemoryJob.status` returns a `TranslationMemoryJobStatus` member
 (`AWAITING_INPUT`, `PROCESSING`, `COMPLETED`, `FAILED` or `EXPIRED`), or the
 plain string for a status the library does not know. Members are strings and

deepl/deepl_client.py

@@ -2061,6 +2061,9 @@ def upload_translation_memory_file(
             .. deprecated::
                 Use content instead. input_file will be removed in the next
                 major version.
+
+        :raises DeepLException: If the storage URL returns an error status,
+            with http_status_code set; should_retry is True for 429 and 5xx.
         """
         if input_file is not None:
             if content is not None:
@@ -2206,6 +2209,9 @@ def download_translation_memory_export(
             default 64 KiB. Only used if output_file is specified.
         :return: None if output_file is specified, otherwise the
             requests.Response.
+
+        :raises DeepLException: If the storage URL returns an error status,
+            with http_status_code set; should_retry is True for 429 and 5xx.
         """
         download_url = job.result.download_url if job.result else None
         if not download_url:
@@ -2361,10 +2367,21 @@ def _raise_for_asset_status(
     ) -> None:
         if 200 <= status_code < 300:
             return
-        detail = content if isinstance(content, str) else ""
+        if isinstance(content, requests.Response):
+            # A streamed download: read the error body for the message.
+            try:
+                detail = content.text
+            except requests.exceptions.RequestException:
+                detail = ""
+        else:
+            detail = content
         message = f"Error {action}, HTTP status: {status_code}"
         if detail:
             message += f", detail: {detail}"
+        # Storage URLs are not DeepL API endpoints, so every error is a plain
+        # DeepLException; 429 and 5xx are retryable as for the API.
         raise DeepLException(
-            message, should_retry=False, http_status_code=status_code
+            message,
+            should_retry=status_code == 429 or status_code >= 500,
+            http_status_code=status_code,
         )

tests/offline/test_translation_memories.py

@@ -369,6 +369,24 @@ def test_raises_with_status_and_detail_when_storage_rejects_upload(mocked):
     assert exc_info.value.http_status_code == 403
 
 
+@pytest.mark.parametrize(
+    "status, should_retry",
+    [(429, True), (500, True), (503, True), (403, False)],
+)
+def test_marks_storage_errors_retryable_for_429_and_5xx(
+    mocked, no_retries, status, should_retry
+):
+    mocked.put(UPLOAD_URL, status=status)
+
+    with pytest.raises(deepl.DeepLException) as exc_info:
+        make_deepl_client().upload_translation_memory_file(UPLOAD_URL, b"x")
+
+    # A plain DeepLException: storage URLs are not DeepL API endpoints.
+    assert type(exc_info.value) is deepl.DeepLException
+    assert exc_info.value.http_status_code == status
+    assert exc_info.value.should_retry is should_retry
+
+
 @pytest.mark.parametrize("status, reused", [(200, True), (202, False)])
 def test_marks_export_as_reused_when_server_returns_200(
     mocked, status, reused
@@ -681,15 +699,16 @@ def test_raises_when_downloading_export_without_download_url():
         make_deepl_client().download_translation_memory_export(job)
 
 
-def test_raises_when_storage_rejects_download(mocked):
-    mocked.get(DOWNLOAD_URL, status=404)
+def test_raises_with_body_when_storage_rejects_streamed_download(mocked):
+    mocked.get(DOWNLOAD_URL, status=404, body="no such key")
     job = TranslationMemoryJob.from_json(
         job_json("completed", "export", download_url=DOWNLOAD_URL)
     )
 
     with pytest.raises(
         deepl.DeepLException,
-        match="downloading translation memory export, HTTP status: 404",
+        match="downloading translation memory export, HTTP status: 404, "
+        "detail: no such key",
     ):
         make_deepl_client().download_translation_memory_export(
             job, io.BytesIO()