fix: type the StyleProfile timestamps as required dates

creationTime and updatedTime were optional, although the API always
returns them. They are now required Date fields; a missing or malformed
value parses to an invalid Date instead of undefined.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: hive-bot

src/parsing.ts

@@ -896,8 +896,9 @@ function parseRawStyleProfile(obj: StyleProfileApiResponse): StyleProfile {
         styleRuleIds: parseIdList(obj.style_rule_ids),
         translationMemoryIds: parseIdList(obj.translation_memory_ids),
         glossaryPriorityOrderEnabled: obj.glossary_priority_order_enabled === true,
-        creationTime: parseOptionalTimestamp(parseOptionalString(obj.creation_time)),
-        updatedTime: parseOptionalTimestamp(parseOptionalString(obj.updated_time)),
+        // Required on the wire; a missing or malformed value gives an invalid Date, never a throw
+        creationTime: new Date(parseOptionalString(obj.creation_time) ?? NaN),
+        updatedTime: new Date(parseOptionalString(obj.updated_time) ?? NaN),
     };
 }
 

src/types.ts

@@ -1063,10 +1063,10 @@ export interface StyleProfile {
     readonly translationMemoryIds: string[];
     /** Whether the order of glossaryIds sets the priority of the glossaries. */
     readonly glossaryPriorityOrderEnabled: boolean;
-    /** Time when the style profile was created; undefined if the API returned no valid time. */
-    readonly creationTime?: Date;
-    /** Time of the last update; undefined if the API returned no valid time. */
-    readonly updatedTime?: Date;
+    /** Time when the style profile was created. */
+    readonly creationTime: Date;
+    /** Time when the style profile was last updated. */
+    readonly updatedTime: Date;
 }
 
 /**

tests/offline/styleProfiles.test.ts

@@ -221,11 +221,13 @@ describe('DeepLClient.getStyleProfile', () => {
         expect(fetched).toStrictEqual({ ...profile, description: undefined, industry: undefined });
     });
 
-    it('tolerates a malformed timestamp and non-string IDs', async () => {
+    it('tolerates malformed or missing timestamps and non-string IDs', async () => {
+        const { updated_time: updatedTime, ...withoutUpdatedTime } = profileReply;
+        void updatedTime;
         nock(serverUrl)
             .get(`/v3/style_profiles/${profileId}`)
             .reply(200, {
-                ...profileReply,
+                ...withoutUpdatedTime,
                 creation_time: 'not a timestamp',
                 glossary_ids: ['g-1', 42, null, 'g-2'],
                 style_rule_ids: null,
@@ -235,9 +237,15 @@ describe('DeepLClient.getStyleProfile', () => {
 
         const fetched = await makeDeeplClient().getStyleProfile(profileId);
 
+        // The timestamps are required, so they are invalid Dates rather than undefined
+        expect(fetched.creationTime).toBeInstanceOf(Date);
+        expect(fetched.creationTime.getTime()).toBeNaN();
+        expect(fetched.updatedTime).toBeInstanceOf(Date);
+        expect(fetched.updatedTime.getTime()).toBeNaN();
         expect(fetched).toStrictEqual({
             ...profile,
-            creationTime: undefined,
+            creationTime: fetched.creationTime,
+            updatedTime: fetched.updatedTime,
             glossaryIds: ['g-1', 'g-2'],
             styleRuleIds: [],
             translationMemoryIds: [],