fix: map storage-URL errors of the export download as released

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: hive-bot

CHANGELOG.md

@@ -325,11 +325,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   `exportTranslationMemoryToFilepath()` keep polling on an unknown status or a
   job without results instead of rejecting; the timeout bounds the wait.
 - Translation memory and job IDs are URL-encoded in request paths.
-- `downloadTranslationMemoryExport()` and `exportTranslationMemoryToFilepath()`
-  throw a plain `DeepLError` with `httpStatusCode` (and `shouldRetry` true for
-  429 and 5xx) when the pre-signed download URL answers an error. Before, the
-  status went through the DeepL API mapping, so for example an expired URL (403)
-  threw `AuthorizationError` and a 503 threw `DocumentNotReadyError`.
 - `exportTranslationMemoryToFilepath()` checks for an existing output file and
   an unwritable or missing output directory before it creates the export job,
   and throws the same Node error (`EEXIST`, `ENOENT`, `EACCES`) as before;

README.md

@@ -1500,7 +1500,9 @@ connections, unreachable hosts or networks and connect timeouts), as resending i
     requests throw its deprecated subclass `GlossaryNotFoundError`.
 -   `TooManyRequestsError`: HTTP 429, after all retries.
 -   `QuotaExceededError`: HTTP 456, the quota of the billing period is used up.
--   `DocumentNotReadyError`: HTTP 503 while downloading a translated document.
+-   `DocumentNotReadyError`: HTTP 503 while getting the status of a document
+    translation, downloading a translated document or downloading a
+    translation memory export.
 -   `ConnectionError`: the request got no HTTP response, for example a timeout.
 -   `DocumentTranslationError`: a document translation failed. The cause is in
     its `error` property, and `httpStatusCode` and `shouldRetry` are copied

src/deeplClient.ts

@@ -129,7 +129,7 @@ function spokenTermsEntriesToJson(entries: SpokenTermsEntries): Record<string, u
 }
 
 /**
- * Throws a plain DeepLError for a failed response from a pre-signed storage URL. These are not
+ * Throws a plain DeepLError for a failed upload to a pre-signed storage URL. These are not
  * DeepL API responses, so the API's status code mapping (e.g. 403 to AuthorizationError) does
  * not apply.
  */
@@ -1539,8 +1539,8 @@ export class DeepLClient extends Translator {
      * @param outputFile: String containing output file path, or a WriteStream to store file data.
      *
      * @throws {DeepLError} If the job has no download URL, or any error occurs while downloading.
-     * An error response from the download URL is a plain DeepLError carrying httpStatusCode,
-     * never one of its subclasses.
+     * An error response from the download URL is mapped like a document download response
+     * (e.g. 403 to AuthorizationError, 503 to DocumentNotReadyError), with httpStatusCode set.
      */
     async downloadTranslationMemoryExport(
         job: Omit<TranslationMemoryJob, 'done' | 'ok' | 'creationTime' | 'updatedTime'>,
@@ -1574,13 +1574,9 @@ export class DeepLClient extends Translator {
                     {},
                     true,
                 );
-            if (statusCode < 200 || statusCode >= 300) {
-                await throwStorageError(
-                    'Error downloading translation memory export',
-                    statusCode,
-                    content,
-                );
-            }
+            // The released status code mapping (e.g. 403 to AuthorizationError, 503 to
+            // DocumentNotReadyError) is kept until the next major version.
+            await checkStatusCode(statusCode, content, false, true);
 
             if (fd === undefined) {
                 return await pipeToStream(content, outputFile as fs.WriteStream);

tests/offline/translationMemories.test.ts

@@ -556,24 +556,19 @@ describe('DeepLClient.downloadTranslationMemoryExport', () => {
     });
 
     it.each([
-        [403, false],
-        [429, true],
-        [503, true],
-    ])(
-        'throws a plain DeepLError when the storage answers %i, with shouldRetry %s',
-        async (status, shouldRetry) => {
-            nock(storageUrl).get('/download').reply(status, 'storage error');
-
-            const error = await makeDeeplClient({ maxRetries: 0 })
-                .downloadTranslationMemoryExport(job(`${storageUrl}/download`), 'unused.tmx')
-                .catch((e) => e);
-
-            // Not AuthorizationError (403) or DocumentNotReadyError (503): storage is not the API
-            expect(error.constructor).toBe(deepl.DeepLError);
-            expect(error.message).toContain('storage error');
-            expect(error).toMatchObject({ httpStatusCode: status, shouldRetry });
-        },
-    );
+        [403, deepl.AuthorizationError, false],
+        [503, deepl.DocumentNotReadyError, true],
+    ])('maps a %i from the storage as released, to %p', async (status, errorClass, shouldRetry) => {
+        nock(storageUrl).get('/download').reply(status, 'storage error');
+
+        const error = await makeDeeplClient({ maxRetries: 0 })
+            .downloadTranslationMemoryExport(job(`${storageUrl}/download`), 'unused.tmx')
+            .catch((e) => e);
+
+        expect(error).toBeInstanceOf(errorClass);
+        expect(error.message).toContain('storage error');
+        expect(error).toMatchObject({ httpStatusCode: status, shouldRetry });
+    });
 
     it('throws ArgumentError when the job has no download URL', async () => {
         await expect(