Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not forwarding email extras when sharing #1650

Closed
3 tasks
fabiancrx opened this issue Apr 22, 2024 · 0 comments · Fixed by #1651
Closed
3 tasks

Not forwarding email extras when sharing #1650

fabiancrx opened this issue Apr 22, 2024 · 0 comments · Fixed by #1651
Labels
bug Something isn't working needs triage

Comments

@fabiancrx
Copy link
Contributor

fabiancrx commented Apr 22, 2024

Describe the bug
When sharing a PDF via PDFPreview if its attributes shareActionExtraBody, shareActionExtraEmails or shareActionExtraSubject are configured, they don't get prefilled when sharing via email

To Reproduce
Code snippet to reproduce the behavior:

PdfPreview(
                canDebug: false,
                canChangeOrientation: false,
                shareActionExtraBody: "shareActionExtraBody",
                shareActionExtraEmails: ["[email protected]"],
                shareActionExtraSubject: "shareActionExtraSubject",
                build: (format) => PdfJobReportExporter().buildPdf(format),
              )

Expected behavior
When an email app is opened the recipients, subject and body get prefilled

Screenshots

Flutter Doctor

[✓] Flutter (Channel stable, 3.19.5, on macOS 14.4.1 23E224 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✗] Chrome - develop for the web (Cannot find Chrome executable at /opt/brave.com/brave/brave-browser)
    ! /opt/brave.com/brave/brave-browser is not executable.
[!] Android Studio (version unknown)
    ✗ Unable to determine Android Studio version.
[✓] VS Code (version 1.88.0)
[✓] Connected device (2 available)
[✓] Network resources

Desktop (please complete the following information):

  • [ x] iOS
  • [ x] Android
  • Browser
  • Windows
  • Linux

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Created a PR that fixes this issue, the underlying code was there, it was just not forwarding the specified parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant