Skip to content

Commit fa1c698

Browse files
authored
MINOR: Merge pull request #7 from Datatamer/add-deletion-protection-cloudsql
DEV-14982 Add deletion_protection for cloud sql instance
2 parents 47c1a4e + 72715d9 commit fa1c698

File tree

6 files changed

+24
-19
lines changed

6 files changed

+24
-19
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Tamr GCP Wrapper - v0.4.0 - August 18th 2021
2+
* Plumb through deletion_protection for cloud sql instance
3+
14
# Tamr GCP Wrapper - v0.2.1 - August 3rd 2020
25
* Remove direct invocation of GLB module
36
* update docs with more examples

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ No provider.
6060
| additional\_admin\_users | list of additional entities to give admin permissions to provisioned resources | `list(string)` | `[]` | no |
6161
| additional\_read\_users | list of additional entities to give read only permissions to provisioned resources | `list(string)` | `[]` | no |
6262
| bucket\_locations | Location for the gcs buckets, default is `US` | `string` | `"US"` | no |
63-
| force\_destroy | force destroy potentially persistent resources, like bigtable/gcs | `bool` | `false` | no |
63+
| force\_destroy | force destroy potentially persistent resources, like bigtable/gcs/cloud sql instance | `bool` | `false` | no |
6464
| labels | Labels to attach to created resources | `map(string)` | `{}` | no |
6565
| sql\_disk\_size | size of the disk to use on the tamr sql instance | `number` | `10` | no |
6666
| sql\_disk\_type | The disk type to use on the cloud SQL instance. should be either PD\_SSD or PD\_STANDARD | `string` | `"PD_SSD"` | no |

examples/load_balancer/main.tf

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
locals {
2-
deployment_name = "tamr-dev"
3-
project = "your-project"
4-
region = "us-east1"
5-
zone = "us-east1-b"
2+
deployment_name = "tamr-dev"
3+
project = "your-project"
4+
region = "us-east1"
5+
zone = "us-east1-b"
66
}
77

88
module "tamr_stack" {
9-
source = "git::[email protected]:Datatamer/terraform-gcp-tamr-vm.git?ref=v0.1.0"
9+
source = "git::[email protected]:Datatamer/terraform-gcp-tamr-vm.git?ref=v0.1.0"
1010
deployment_name = local.deployment_name
1111
# tamr VM
12-
tamr_zip_uri = "gs://tamr-releases/v2020.015.0/unify.zip"
12+
tamr_zip_uri = "gs://tamr-releases/v2020.015.0/unify.zip"
1313
tamr_instance_image = "your-project/ubuntu"
1414
# bigtable config
15-
tamr_bigtable_min_nodes = 1
16-
tamr_bigtable_max_nodes = 10
15+
tamr_bigtable_min_nodes = 1
16+
tamr_bigtable_max_nodes = 10
1717
# network
1818
subnet_self_link = data.google_compute_subnetwork.project_subnet.self_link
19-
region = local.region
20-
zone = local.zone
19+
region = local.region
20+
zone = local.zone
2121
# misc
2222
# NOTE: this module will deploy all resources into this project
2323
project_id = local.project

examples/minimal/main.tf

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
module "tamr_stack" {
2-
source = "git::[email protected]:Datatamer/terraform-gcp-tamr-vm.git?ref=v0.1.0"
2+
source = "git::[email protected]:Datatamer/terraform-gcp-tamr-vm.git?ref=v0.1.0"
33
deployment_name = "tamr-dev"
44
# tamr VM
5-
tamr_zip_uri = "gs://tamr-releases/v2020.015.0/unify.zip"
5+
tamr_zip_uri = "gs://tamr-releases/v2020.015.0/unify.zip"
66
tamr_instance_image = "your-project/ubuntu"
77
# bigtable config
8-
tamr_bigtable_min_nodes = 1
9-
tamr_bigtable_max_nodes = 10
8+
tamr_bigtable_min_nodes = 1
9+
tamr_bigtable_max_nodes = 10
1010
# network
1111
subnet_self_link = data.google_compute_subnetwork.project_subnet.self_link
12-
region = "us-east1"
13-
zone = "us-east1-b"
12+
region = "us-east1"
13+
zone = "us-east1-b"
1414
# misc
1515
# NOTE: this module will deploy all resources into this project
1616
project_id = "your-project"

main.tf

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,15 @@ module "iam" {
2828
}
2929

3030
module "cloud_sql" {
31-
source = "git::[email protected]:Datatamer/terraform-gcp-tamr-cloud-sql.git?ref=v2.1.0"
31+
source = "git::[email protected]:Datatamer/terraform-gcp-tamr-cloud-sql.git?ref=v4.6.0"
3232
name = var.deployment_name
3333

3434
project_id = var.project_id
3535
labels = var.labels
3636
region = var.region
3737

38+
deletion_protection = local.deletion_protection
39+
3840
cloud_sql_viewer_members = local.read_users
3941
cloud_sql_client_members = local.admin_users
4042

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,5 +117,5 @@ variable "labels" {
117117
variable "force_destroy" {
118118
default = false
119119
type = bool
120-
description = "force destroy potentially persistent resources, like bigtable/gcs"
120+
description = "force destroy potentially persistent resources, like bigtable/gcs/cloud sql instance"
121121
}

0 commit comments

Comments
 (0)