Skip to content

Upgrade ingress-nginx to v1.11.5 or 1.12.1 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
artntek opened this issue Mar 25, 2025 · 2 comments
Closed

Upgrade ingress-nginx to v1.11.5 or 1.12.1 #62

artntek opened this issue Mar 25, 2025 · 2 comments
Assignees

Comments

@artntek
Copy link
Contributor

artntek commented Mar 25, 2025

In response to this vulnerability report: https://groups.google.com/g/kubernetes-security-announce/c/2qa9DFtN0cQ - we should upgrade ingress-nginx to v1.11.5 or 1.12.1

Note

Neither the dev or prod clusters are currently vulnerable, because the Validating Admission Controller functionality of ingress-nginx is already disabled, since the helm install options we used included:

--set controller.admissionWebhooks.enabled=false

Double-checking that we don't have a ValidatingWebhookConfiguration called ingress-nginx-admission:

$ kc get ValidatingWebhookConfiguration                                 (☸|prod-k8s:default)
NAME                   WEBHOOKS   AGE
cert-manager-webhook   1          3y147d

However, we're not sure why Peter originally recommended disabling it, and re-enabling it (after we upgrade) "provides important safeguards for your Ingress configurations", so we should consider doing so

Other Info

Useful Background:

@artntek artntek self-assigned this Mar 25, 2025
@artntek
Copy link
Contributor Author

artntek commented Mar 25, 2025

Also note that ingress-nginx is being replaced with Ingate: kubernetes/ingress-nginx#13002

@artntek
Copy link
Contributor Author

artntek commented May 21, 2025

Upgraded both dev and prod to ingress-nginx chart v4.11.6 (app v1.11.6), and set controller.admissionWebhooks.enabled=true

Note we can't upgrade to chart 4.12.* until we upgrade k8s to 1.28 or higher

@artntek artntek closed this as completed May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant